Skip to content

feat(manager): let the host pass its own chainforks schedule ✨ - #87

Merged
kp2pml30 merged 1 commit into
v0.6-devfrom
feat/host-chainforks
Nov 12, 2026
Merged

kp2pml30 merged 1 commit into
v0.6-devfrom
feat/host-chainforks

Conversation

@kp2pml30

@kp2pml30 kp2pml30 commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Delivery Context

Bottom of stack #89 and the current landing cut of round 1, driven from genlayerlabs/genlayer-studio#1824, which depends on this PR. #88 above is a review layer for round 2: do not post /merge there yet

Problem and Outcome

Production networks are host business, but the manager hardcodes them in its shipped schedule. Now a host hands the manager its own schedule and default network, the same way it already can for the manifest

  • --chainforks-path and --default-network override chainforks_path and default_network, both for serving and for check-install, on either side of the subcommand
  • default_network may be null: a request naming no network is then rejected, detect-version with 400 and a run with failed_to_start. The key itself stays required
  • check-install validates default_network only when one is set
  • Studio now ships its own schedule, so the studio network leaves the shipped one. The shipped default_network stays bradbury-phase2 until feat(manager): ship only the dev network and no default network ✨ #88, because current nodes send no network when they have none

Non-goal: removing the production networks, which is #88

Implementation and Validation

  • Host-only forks such as node/* are accepted: defined and scheduled, they reach the executor in --forks, and every executor line ignores fork names that no runner uses. A test covers it
  • Unit: 87 manager tests pass, covering flag parsing on both sides of the subcommand, overrides, null default and a request without a network
  • Real runs of genvm-modules manager check-install against a node-style schedule: bradbury-phase2 and clarke pass; an unknown network or a missing executor fork exits 1

Summary by CodeRabbit

  • New Features
    • Manager configuration can now specify no default network. Requests without an explicit network are rejected when no default is configured.
    • Hosts can provide fork schedules through configuration or command-line overrides. Host-defined forks are passed through to the executor; forks required by a manifest or runner must be present in the host schedule.
  • Documentation
    • Updated manager API, socket, and setup documentation to describe network selection, request failures, and host fork schedule requirements.

- `--chainforks-path` and `--default-network` override the config for serving and `check-install`, on either side of the subcommand
- `default_network` may be null: a request naming no network is then rejected, detect-version with 400 and a run with `failed_to_start`
- `check-install` validates `default_network` only when one is set
- Studio ships its own schedule, so the `studio` network leaves the shipped one
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The manager now allows default_network to be null, applies CLI configuration overrides through shared loading, and uses common network selection for version detection and run requests. Documentation and tests describe and verify the updated behavior.

Changes: Network configuration and resolution

Layer / File(s) Summary
Shared configuration loading and network selection
implementation/src/manager/mod.rs, implementation/src/manager/check_install.rs, implementation/src/manager/tests.rs
default_network remains a required configuration key but may be null. Config::network selects the requested network or configured default, and returns an error if neither is present. Shared loading applies supplied CLI overrides. Tests cover parsing, selection, and override behavior.
Runtime network handling and documentation
implementation/src/manager/mod.rs, implementation/src/manager/run.rs, implementation/src/manager/versioning.rs, docs/contributing/howto/extending/modify-runner.md, docs/website/src/impl-spec/appendix/manager-api.yaml, docs/website/src/impl-spec/appendix/manager-socket.rst
Version detection and run requests use shared network selection. Default-network validation is skipped when no default is configured. The documentation describes missing-network failures and host fork-schedule handling.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Possibly related PRs

Merge Risk: Minimal · up to 9b989

The change lets hosts supply their own chainforks schedule and default network, and a null default now rejects requests that name no network. No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "feat(manager): let the host pass its own chainforks schedule" matches the main change. The PR adds host-supplied chainforks schedule and default network support. The changed files in implem…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "feat(manager): let the host pass its own chainforks schedule" matches the main change. The PR adds host-supplied chainforks schedule and default network support. The changed files in implementation/src/manager (mod.rs, run.rs, versioning.rs, check_install.rs, tests.rs) and the docs back this up. The title does not cover the nullable default_network or the studio removal, but the task allows that.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Clippy (1.99.1)

Clippy execution failed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 71a60f9 and 9b98991.

Files ignored due to path filters: 5

  • docs/schemas/default-config.json is excluded by !**/*.json
  • implementation/src/manager/chainforks_test.rs is excluded by !**/*_test.rs
  • implementation/src/manager/run_test.rs is excluded by !**/*_test.rs
  • implementation/src/manager/versioning_test.rs is excluded by !**/*_test.rs
  • install/data/genvm-chainforks.json is excluded by !**/*.json
Files selected for processing: 8

  • docs/contributing/howto/extending/modify-runner.md
  • docs/website/src/impl-spec/appendix/manager-api.yaml
  • docs/website/src/impl-spec/appendix/manager-socket.rst
  • implementation/src/manager/check_install.rs
  • implementation/src/manager/mod.rs
  • implementation/src/manager/run.rs
  • implementation/src/manager/tests.rs
  • implementation/src/manager/versioning.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

Copy link
Copy Markdown

GenVM PR actions

Tick a box to run it (the box unticks itself when handled). Actions only run while the PR has the ci-safe label.

  • Force run full tests
  • Provision executor PRs
Commands
  • /genvm-run-tests — run full tests once for the current manager snapshot
  • /merge — queue the exact manager snapshot through the App-owned E2E merge train

@kp2pml30
kp2pml30 added this pull request to stack #89 November 12, 2026 12:23
@kp2pml30 kp2pml30 changed the title feat/host chainforks feat(manager): let the host pass its own chainforks schedule ✨ Nov 12, 2026
@kp2pml30
kp2pml30 marked this pull request as ready for review November 12, 2026 12:24
@kp2pml30

Copy link
Copy Markdown
Member Author

/genvm-run-tests

@github-actions

Copy link
Copy Markdown

👀 Full tests are running for 9b989918c195: open run #43218152735

@kp2pml30

Copy link
Copy Markdown
Member Author

/genvm-fast-forward

@github-actions

Copy link
Copy Markdown

🚀 Fast-forwarded v0.6-dev to 9b989918c195

Open run

@kp2pml30
kp2pml30 merged commit 9b98991 into v0.6-dev Nov 12, 2026
43 of 48 checks passed
@kp2pml30
kp2pml30 deleted the feat/host-chainforks branch November 12, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant