Repository navigation
feat(manager): let the host pass its own chainforks schedule ✨ - #87
Conversation
- `--chainforks-path` and `--default-network` override the config for serving and `check-install`, on either side of the subcommand - `default_network` may be null: a request naming no network is then rejected, detect-version with 400 and a run with `failed_to_start` - `check-install` validates `default_network` only when one is set - Studio ships its own schedule, so the `studio` network leaves the shipped one
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
GenVM PR actionsTick a box to run it (the box unticks itself when handled). Actions only run while the PR has the
Commands
|
|
/genvm-run-tests |
|
👀 Full tests are running for |
|
/genvm-fast-forward |
|
🚀 Fast-forwarded |
Delivery Context
Bottom of stack #89 and the current landing cut of round 1, driven from genlayerlabs/genlayer-studio#1824, which depends on this PR. #88 above is a review layer for round 2: do not post
/mergethere yetProblem and Outcome
Production networks are host business, but the manager hardcodes them in its shipped schedule. Now a host hands the manager its own schedule and default network, the same way it already can for the manifest
--chainforks-pathand--default-networkoverridechainforks_pathanddefault_network, both for serving and forcheck-install, on either side of the subcommanddefault_networkmay be null: a request naming no network is then rejected, detect-version with 400 and a run withfailed_to_start. The key itself stays requiredcheck-installvalidatesdefault_networkonly when one is setstudionetwork leaves the shipped one. The shippeddefault_networkstaysbradbury-phase2until feat(manager): ship only the dev network and no default network ✨ #88, because current nodes send no network when they have noneNon-goal: removing the production networks, which is #88
Implementation and Validation
node/*are accepted: defined and scheduled, they reach the executor in--forks, and every executor line ignores fork names that no runner uses. A test covers itgenvm-modules manager check-installagainst a node-style schedule:bradbury-phase2andclarkepass; an unknown network or a missing executor fork exits 1Summary by CodeRabbit