Skip to content

feat(genvm): own the studio chainforks schedule and hand it to the manager ✨ - #1824

Merged
kp2pml30 merged 2 commits into
v0.123-devfrom
feat/studio-chainforks
Nov 12, 2026
Merged

kp2pml30 merged 2 commits into
v0.123-devfrom
feat/studio-chainforks

Conversation

@kp2pml30

Copy link
Copy Markdown
Member

Delivery Context

Depends-On: genlayerlabs/genvm-manager#87

Hub of the round-1 set: /run-e2e and /merge go here; genvm-manager#87 lands with it

What

  • Studio ships its own GenVM chainforks schedule, backend/node/genvm/chainforks.json, holding the studio network (v0.2 from 2026-01-01T00:00:00Z, v0.3 and v0.4 always)
  • Manager.create runs genvm-modules manager check-install against it (300 s timeout, output in the error), then starts the manager with --chainforks-path <file> --default-network studio
  • The image runs the same check after COPY backend, so a broken schedule fails the build
  • executor_selection.LEGACY_LINE_ACTIVATION is read from the schedule instead of being hardcoded, and a missing or malformed entry fails at import
  • GenVM is pinned to genvm-manager#87 (feat/host-chainforks:9b98991)

Why

genvm-manager#87 stops shipping the studio network: hosts own their networks and hand their schedule to the manager. Until now Studio never ran check-install against its own setup: post-install checks only when precompiling, and only GenVM's shipped schedule

Testing Done

  • Unit: 1839 passed, 7 skipped; new tests/unit/test_genvm_chainforks.py covers the schedule, the argv, the date parse and the Manager.create order, failure and timeout
  • Real genvm-modules manager check-install --chainforks-path backend/node/genvm/chainforks.json --default-network studio on a Simulator - RPC Endpoint to clear the database tables #87 build: succeeds for v0.2.17, v0.3.0, v0.4.0-rc1; --default-network dev and a schedule missing v0.4 both fail
  • 1 backend test is expected to fail on this pin for now

Decisions Made

  • Check-install runs both at build and at startup: docker-compose bind-mounts ./backend, so the build-time check does not cover the file actually served. It costs about 18 s on a debug GenVM build, once per process
  • Setting v0.2 to never in the schedule fails startup, because LEGACY_LINE_ACTIVATION requires a date

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6dfb8ae0-2181-4756-aa97-42422d80a0aa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kp2pml30
kp2pml30 force-pushed the feat/studio-chainforks branch from fba45c7 to c6687f2 Compare November 12, 2026 12:27
@kp2pml30

Copy link
Copy Markdown
Member Author

/run-e2e all

@ci-core-e2e-runner

Copy link
Copy Markdown
Contributor

E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally.

@kp2pml30
kp2pml30 merged commit 01247ba into v0.123-dev Nov 12, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant