Repository navigation
feat(genvm): own the studio chainforks schedule and hand it to the manager ✨ - #1824
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
kp2pml30
force-pushed
the
feat/studio-chainforks
branch
from
November 12, 2026 12:27
fba45c7 to
c6687f2
Compare
Member
Author
|
/run-e2e all |
Contributor
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivery Context
Depends-On: genlayerlabs/genvm-manager#87
Hub of the round-1 set:
/run-e2eand/mergego here; genvm-manager#87 lands with itWhat
backend/node/genvm/chainforks.json, holding thestudionetwork (v0.2 from2026-01-01T00:00:00Z, v0.3 and v0.4always)Manager.createrunsgenvm-modules manager check-installagainst it (300 s timeout, output in the error), then starts the manager with--chainforks-path <file> --default-network studioCOPY backend, so a broken schedule fails the buildexecutor_selection.LEGACY_LINE_ACTIVATIONis read from the schedule instead of being hardcoded, and a missing or malformed entry fails at importfeat/host-chainforks:9b98991)Why
genvm-manager#87 stops shipping the
studionetwork: hosts own their networks and hand their schedule to the manager. Until now Studio never ran check-install against its own setup: post-install checks only when precompiling, and only GenVM's shipped scheduleTesting Done
tests/unit/test_genvm_chainforks.pycovers the schedule, the argv, the date parse and theManager.createorder, failure and timeoutgenvm-modules manager check-install --chainforks-path backend/node/genvm/chainforks.json --default-network studioon a Simulator - RPC Endpoint to clear the database tables #87 build: succeeds for v0.2.17, v0.3.0, v0.4.0-rc1;--default-network devand a schedule missing v0.4 both failDecisions Made
./backend, so the build-time check does not cover the file actually served. It costs about 18 s on a debug GenVM build, once per processneverin the schedule fails startup, becauseLEGACY_LINE_ACTIVATIONrequires a date