Repository navigation
Quieter audits: linked documents, plugins' own caps, hooks and caches - #3
Merged
Merged
Conversation
- Exposed: a downloadable document under uploads that a published post or its fields link to is public on purpose: counted, not flagged, unless its name suggests people's data. The collector lists those links (linked_uploads). - Capabilities an active plugin gives its users itself (WPML's translate, manage_translations, wpml_*) aren't flagged as injection; the rest of a user's extra capabilities still are. - A new scheduled hook with an active plugin's prefix (Yoast's wpseo, WPML, WooCommerce, Gravity Forms, Redirection) is counted, not flagged. - WPML's compiled Twig cache under uploads is counted while WPML is active, only in its exact shape (cache/wpml/twig/<ab>/<ab + 62 hex>.php). Each with the plugin inactive is flagged as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts the noise a real audit showed: of 293 urgent flags on one site, about 290 were documents its pages link to on purpose, plus WPML's own capabilities and cache and Yoast's scheduled hooks.
linked_uploads, a bounded pass like the content scan). A downloadable document that is linked is counted, not flagged, unless its name suggests people's data.translate,manage_translationsandwpml_*aren't flagged as role injection while WPML is active; the rest of a user's extra capabilities still are.wpseo, WPML, WooCommerce, Gravity Forms, Redirection) is counted.uploads/cache/wpml/twig/is counted while WPML is active, only in its exact shape (<ab>/<ab + 62 hex>.php); anything else under uploads stays urgent.With the plugin inactive, each is flagged as before. The plugin table is
owned.go.Tests:
owned_test.gocovers each, active and inactive.🤖 Generated with Claude Code