Skip to content

Quieter audits: linked documents, plugins' own caps, hooks and caches - #3

Merged
oxyc merged 1 commit into
mainfrom
fix/audit-noise
Nov 16, 2026
Merged

oxyc merged 1 commit into
mainfrom
fix/audit-noise

Conversation

@oxyc

@oxyc oxyc commented Nov 16, 2026

Copy link
Copy Markdown
Member

Cuts the noise a real audit showed: of 293 urgent flags on one site, about 290 were documents its pages link to on purpose, plus WPML's own capabilities and cache and Yoast's scheduled hooks.

  • Linked documents. The collector lists the files under uploads that published posts and their fields link to (linked_uploads, a bounded pass like the content scan). A downloadable document that is linked is counted, not flagged, unless its name suggests people's data.
  • Plugins' own capabilities. WPML's translate, manage_translations and wpml_* aren't flagged as role injection while WPML is active; the rest of a user's extra capabilities still are.
  • Plugins' own scheduled hooks. A new hook with an active plugin's prefix (Yoast wpseo, WPML, WooCommerce, Gravity Forms, Redirection) is counted.
  • WPML's Twig cache. PHP under uploads/cache/wpml/twig/ is counted while WPML is active, only in its exact shape (<ab>/<ab + 62 hex>.php); anything else under uploads stays urgent.

With the plugin inactive, each is flagged as before. The plugin table is owned.go.

Tests: owned_test.go covers each, active and inactive.

🤖 Generated with Claude Code

- Exposed: a downloadable document under uploads that a published post or
  its fields link to is public on purpose: counted, not flagged, unless its
  name suggests people's data. The collector lists those links
  (linked_uploads).
- Capabilities an active plugin gives its users itself (WPML's translate,
  manage_translations, wpml_*) aren't flagged as injection; the rest of a
  user's extra capabilities still are.
- A new scheduled hook with an active plugin's prefix (Yoast's wpseo, WPML,
  WooCommerce, Gravity Forms, Redirection) is counted, not flagged.
- WPML's compiled Twig cache under uploads is counted while WPML is active,
  only in its exact shape (cache/wpml/twig/<ab>/<ab + 62 hex>.php).

Each with the plugin inactive is flagged as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@oxyc
oxyc merged commit ff52726 into main Nov 16, 2026
2 checks passed
@oxyc
oxyc deleted the fix/audit-noise branch November 16, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant