Repository navigation
Exposed: media library attachments outside year/month folders are media - #4
Merged
Merged
Conversation
A site that keeps uploads in uploads' root (year/month folders off) had every uploaded brochure flagged urgent: media was recognised only by its folder. The collector now lists documents that are media library attachments (_wp_attached_file, media_files), and those are media wherever they sit: counted, or for review when the name suggests people's data. ACF file fields reference them by ID, which the linked check can't see. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3. On a site that keeps uploads in uploads' root (year/month folders off), 210 uploaded brochures were still flagged urgent: the audit recognised media library uploads only by their year/month folder, and ACF file fields reference them by attachment ID, which the linked check can't see.
The collector now lists the documents that are media library attachments (
_wp_attached_file, asmedia_files; a network site's with itssites/<id>/). Those count as media library uploads wherever they sit: only counted, or flagged for review when the name suggests people's data, as media in year/month folders already were. A document that isn't an attachment stays urgent.Candidatestakes the site facts for this (the runner passes them once the collector is done).Tests:
TestExposedMediaAttachments.🤖 Generated with Claude Code