Skip to content

Exposed: media library attachments outside year/month folders are media - #4

Merged
oxyc merged 1 commit into
mainfrom
fix/attached-media
Nov 16, 2026
Merged

oxyc merged 1 commit into
mainfrom
fix/attached-media

Conversation

@oxyc

@oxyc oxyc commented Nov 16, 2026

Copy link
Copy Markdown
Member

Follow-up to #3. On a site that keeps uploads in uploads' root (year/month folders off), 210 uploaded brochures were still flagged urgent: the audit recognised media library uploads only by their year/month folder, and ACF file fields reference them by attachment ID, which the linked check can't see.

The collector now lists the documents that are media library attachments (_wp_attached_file, as media_files; a network site's with its sites/<id>/). Those count as media library uploads wherever they sit: only counted, or flagged for review when the name suggests people's data, as media in year/month folders already were. A document that isn't an attachment stays urgent.

Candidates takes the site facts for this (the runner passes them once the collector is done).

Tests: TestExposedMediaAttachments.

🤖 Generated with Claude Code

A site that keeps uploads in uploads' root (year/month folders off) had
every uploaded brochure flagged urgent: media was recognised only by its
folder. The collector now lists documents that are media library
attachments (_wp_attached_file, media_files), and those are media wherever
they sit: counted, or for review when the name suggests people's data.
ACF file fields reference them by ID, which the linked check can't see.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@oxyc
oxyc merged commit 566195a into main Nov 16, 2026
2 checks passed
@oxyc
oxyc deleted the fix/attached-media branch November 16, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant