fix: remove Scriban 6.2.0 NuGet audit suppressions - #403
Draft
dnyw4l3n13 wants to merge 2 commits into
Draft
Conversation
FunFair.BuildCheck's MustHaveIncludeAssetsOnPackageReference policy requires every direct PackageReference to declare IncludeAssets. Pre-existing on main; found while running the mandatory pre-work buildcheck as part of #352. Claude-Session: https://claude.ai/code/session_01MbBmudQ42gXgD9n3xVTYsJ
Mediator.SourceGenerator was bumped to 3.0.2, whose nuspec no longer depends on Scriban, so the transitive dependency that triggered the NU1902/NU1903 audit warnings is gone. Verified with a clean restore and build: 0 warnings/errors, and Scriban does not appear in any project's restored project.assets.json. Closes #352 Claude-Session: https://claude.ai/code/session_01MbBmudQ42gXgD9n3xVTYsJ
Member
Roslyn analyzer findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
NuGetAuditSuppressentries for Scriban 6.2.0 advisories inBuildBot/BuildBot.csprojandBuildBot.Discord/BuildBot.Discord.csproj.Mediator.SourceGeneratorwas bumped to 3.0.2 (already onmain), whose nuspec no longer depends on Scriban, so the transitive dependency that triggered NU1902/NU1903 is gone.Also includes a separate commit fixing 46 pre-existing
FunFair.BuildCheckMustHaveIncludeAssetsOnPackageReferencefailures found while running the mandatory pre-work buildcheck (unrelated to Scriban, but blocking the commit gate).Closes #352
How Has This Been Tested
dotnet buildcheck -Solution BuildBot.slnx(no errors),dotnet build BuildBot.sln(0 warnings/errors), all 8 test projects run individually (242 tests passed, 0 failed). Note:dotnet test BuildBot.slnat the solution level reports "Zero tests ran" for every project on this repo - a pre-existing Microsoft.Testing.Platform/solution quirk confirmed identical onmain, unrelated to this change.Types of changes
Deployment Configuration Changes
Checklist
run:/script:body (workflow or composite action); pass it via step-levelenv:and reference$VAR(bash) orprocess.env.VAR(github-script) instead.https://claude.ai/code/session_01MbBmudQ42gXgD9n3xVTYsJ