Repository navigation
Conversation
…rol back names 0.21.39 no longer says "in-app back control is not available" or "Unable to dismiss the iOS keyboard", so the fallbacks Explore keyed on those messages would never run. They now read error.details.reason: - back: on iOS, agent-device presses the navigation bar back button, else swipes from the left edge, and refuses with back_swipe_no_change when nothing changed. It lists the screen's dismiss controls (Close, Cancel, Back) in details.dismissControls without pressing them. Explore presses the one it names when its label is safe by Explore's destructive and external rules, requires the destination to change, and otherwise swipes a sheet down as before. - keyboard dismiss refuses with keyboard_dismiss_unavailable; the return-key fallback keys on it. - the remote /health refusal is remote_daemon_unavailable with dispatched "no", which is what Explore inferred from the message before resending. The other controller's bridge gives the same reasons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
As in source-driven capture, explore:binary compares the screen before and after it presses the dismiss control agent-device named, and fails the back with agent-device's refusal when nothing changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ipes after a press A modal kept in a screen's own state keeps the route when its Close control dismisses it, so the destination check alone read that as a failure and fell through to the sheet swipe-down with the geometry read before the press. A press now counts when the route changes or the pressed control is gone. If neither happens, back fails with AGENT_DISMISS_CONTROL_FAILED instead of swiping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eaving the screen The pressed control disappearing counted as back, but a confirmation such as "Discard changes?" also hides it while the screen stays. The control leaving now counts only when no alert took its place; otherwise back fails with AGENT_DISMISS_CONTROL_FAILED. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A "Discard changes?" confirmation after the press changes the screen, and can hide the route observer, so either signal alone read it as having left. Both code paths now require that no alert is showing before a press counts as back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
agent-device names a dismiss control by its identifier when it has one, and its label may then be empty. The press check matched only the label, so a button with no label was never seen and the press counted as leaving even when the modal stayed. It now matches the control the way agent-device named it, and the control leaving counts only when it was on screen before the press. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thymikee
force-pushed
the
agent-device-keyboard-status
branch
from
November 19, 2026 15:28
0d7c688 to
be04540
Compare
0.21.40 adds the keyboard fix found while testing this bump: keyboard dismiss no longer presses the return key, so on a field whose return key is Done it refuses with keyboard_dismiss_unavailable instead of submitting the form. The typed reasons Explore reads are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When agent-device reports keyboard_dismiss_unavailable, the fallback tapped the keyboard's return key by coordinates. That key never only closes the keyboard: next moves focus to the following field, and done or go submits the form (expo#88). The step now fails with KEYBOARD_DISMISS_UNAVAILABLE and names the app's own controls as the next action. This also removes the multi-line editor guard and the return-key label pattern, which only served the coordinate tap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thymikee
force-pushed
the
agent-device-keyboard-status
branch
from
November 19, 2026 16:28
be04540 to
20cc5fc
Compare
The model read only an error's message, so agent-device's next step never reached it: how to leave a modal back cannot close, or that a visible iOS keyboard needs its Hide Keyboard key or an app control that ends editing. A failed action now reads the message followed by that hint. dismiss-keyboard passes agent-device's refusal through as it is, instead of rewording it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The other controller's bridge refused keyboard dismiss without a hint, so the model got generic advice there. Its refusals now give the same next step as agent-device's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #88. We want Explore to use agent-device directly, without workarounds. This removes one. When agent-device refused
keyboard dismisswithkeyboard_dismiss_unavailable,dismiss-keyboardfound the return key in the tree and tapped it. That key never only closes the keyboard. Onnextit moves focus, and ondoneorgoit submits the form.From 0.21.40 (pinned in #87), agent-device dismisses no visible iOS keyboard itself. Instead, its refusal tells the caller what to do. Explore now passes that on rather than guessing:
dismiss-keyboardsendskeyboard dismissand nothing else. A refusal reaches the model unchanged.backon a modal.This deletes the coordinate tap,
KEYBOARD_RETURN_KEYand the multi-line guard. 6 files changed.No change to usage.
Stacked on #87: review after it. The diff includes #87's commits until it merges.
Validation
Tested at head
3813b5a(the bridge hint in 68d2d18 is covered by unit tests) withexplore:binary --simulator localon an iPhone 17 Pro (iOS 27.0). The Wallet plan opens sign-up, fills name, email and password, then runs an optionaldismiss-keyboardand a capture:dismiss-keyboardbuild,typecheckandeslintpass.test:node: 1692 pass. The 29 failures are the known "evidence comparison did not run" set. Explore's CI needs maintainer approval for fork PRs.🤖 Generated with Claude Code
🟢 Devin Review found nothing to fix · View findings · Follow Devin's work