Repository navigation
Conversation
…rol back names 0.21.39 no longer says "in-app back control is not available" or "Unable to dismiss the iOS keyboard", so the fallbacks Explore keyed on those messages would never run. They now read error.details.reason: - back: on iOS, agent-device presses the navigation bar back button, else swipes from the left edge, and refuses with back_swipe_no_change when nothing changed. It lists the screen's dismiss controls (Close, Cancel, Back) in details.dismissControls without pressing them. Explore presses the one it names when its label is safe by Explore's destructive and external rules, requires the destination to change, and otherwise swipes a sheet down as before. - keyboard dismiss refuses with keyboard_dismiss_unavailable; the return-key fallback keys on it. - the remote /health refusal is remote_daemon_unavailable with dispatched "no", which is what Explore inferred from the message before resending. The other controller's bridge gives the same reasons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
As in source-driven capture, explore:binary compares the screen before and after it presses the dismiss control agent-device named, and fails the back with agent-device's refusal when nothing changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ipes after a press A modal kept in a screen's own state keeps the route when its Close control dismisses it, so the destination check alone read that as a failure and fell through to the sheet swipe-down with the geometry read before the press. A press now counts when the route changes or the pressed control is gone. If neither happens, back fails with AGENT_DISMISS_CONTROL_FAILED instead of swiping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eaving the screen The pressed control disappearing counted as back, but a confirmation such as "Discard changes?" also hides it while the screen stays. The control leaving now counts only when no alert took its place; otherwise back fails with AGENT_DISMISS_CONTROL_FAILED. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A "Discard changes?" confirmation after the press changes the screen, and can hide the route observer, so either signal alone read it as having left. Both code paths now require that no alert is showing before a press counts as back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
agent-device names a dismiss control by its identifier when it has one, and its label may then be empty. The press check matched only the label, so a button with no label was never seen and the press counted as leaving even when the modal stayed. It now matches the control the way agent-device named it, and the control leaving counts only when it was on screen before the press. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0.21.40 adds the keyboard fix found while testing this bump: keyboard dismiss no longer presses the return key, so on a field whose return key is Done it refuses with keyboard_dismiss_unavailable instead of submitting the form. The typed reasons Explore reads are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We maintain agent-device, and we'd like Explore to use what it offers directly rather than work around it. When we find a gap that forces Explore into a workaround, we fix it in agent-device first, then send the matching change here.
This PR bumps agent-device from
0.21.29-nightly.20261018.74to0.21.40. Newer releases reword two error messages that Explore matches as text, so on a plain bump those fallbacks would quietly stop running. All three text checks now read the typederror.details.reason:back_swipe_no_changekeyboard_dismiss_unavailable/healthfailedremote_daemon_unavailablewithdispatched: "no", so a resend is safeOn iOS,
backnow only pops the navigation stack. On a modal whose only exit is a header Close button, agent-device names that button instead of guessing:{ "reason": "back_swipe_no_change", "dismissControls": [{ "selector": "role=button label=\"Close\"", "label": "Close" }] }Explore presses that button only when it's the only one listed and
riskOfcalls it safe. Back then succeeds only if the screen changes or the button disappears, and no alert appears. The other controller's bridge returns the same reasons. 13 files changed.No visible change. No change to usage.
Validation
Tested at head b36e438 on a local iPhone 17 Pro simulator (iOS 27.0), with a 24-step
explore:binary --replayof the Wallet example:backon/topupThis PR captured one extra screen: the keyboard mid-typing on sign-up.
npm run test:node: the new tests pass. The same 29 that fail on main also fail here, all in the comparator ("evidence comparison did not run"). Typecheck and lint pass. Your CI hasn't run yet, because this PR comes from a fork.Also found: #88, where
dismiss-keyboardcan submit a form. 0.21.40 fixes the agent-device side; #91 fixes Explore's side.🤖 Generated with Claude Code