Repository navigation
ci: run the macOS native checks on the self-hosted macOS executor #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Uncredentialed macOS checks lose local fallback
When neither optional BuildBuddy secret is set,
BAZEL_CONFIGstill selectsremote_macoson a Linux runner. The explicit config overrides configure-buildbuddy.sh's local fallback, so both native checks fail without credentials.Learn more
The reusable native workflow declares both BuildBuddy secrets optional. When neither is set, the credential setup writes a local Bazel configuration, but the macOS matrix still selects an Ubuntu runner and passes
--config=remote_macos. A command-line config takes precedence over the fallback, leaving the build pointed at the remote executor without credentials. The two macOS jobs cannot run their native tests on that Linux runner.Example: Run the CI workflow on main in a repository where neither BuildBuddy secret is configured. The CSV and YAML macOS jobs start on Ubuntu and invoke remote execution without a key; previously they started on
macos-15and ran locally.Recommended fix: Gate both
runs-onandBAZEL_CONFIGon the presence of a BuildBuddy key as well as the trusted-event condition, while keeping the secret out of logs and action environments.Was this helpful? React with 👍 or 👎 to provide feedback.