Skip to content

ci: run the macOS native checks on the self-hosted macOS executor - #124

Merged
Sam Gammon (sgammon) merged 1 commit into
mainfrom
ci/macos-rbe
Nov 17, 2026
Merged

Sam Gammon (sgammon) merged 1 commit into
mainfrom
ci/macos-rbe

Conversation

@sgammon

Copy link
Copy Markdown
Member

Runs the aarch64-apple-darwin CSV and YAML native checks on our self-hosted macOS arm64 BuildBuddy executor instead of building on a hosted macos-15 runner.

  • //bazel/platforms:rbe_macos_arm64 routes to the executor with OSFamily=darwin, Arch=arm64, use-self-hosted-executors=true and Pool=komodo-release-macos-arm64. The pool comes from MY_POOL in the executor's launchd job.
  • --config=remote_macos uses its own cache namespace (elide-dev/truffledata/macos/v1): the macOS C/C++ wrapper selects the executor's SDK outside the action keys, so these results must not share cache entries with Linux or with developer machines.
  • Workflow: trusted runs drive the macOS jobs from an Ubuntu runner with --config=remote_macos. Fork PRs get no BuildBuddy key, so they keep macos-15 and --config=local rather than skipping the check.

Why: on the 0.14.0 release commit, the hosted macOS YAML job hit the job timeout on a slow runner. Its rerun passed in under 5 minutes. The same YAML tests (api_test, input_test, stream_test, yaml_archive_test) pass on the remote executor in about 80 s.

Verified: those four YAML targets on the executor, driven from a Mac. Not yet verified: driving it from a Linux host, and the CSV and shared-loading/ThinLTO targets remotely. This PR's own CI run covers both.

🤖 Generated with Claude Code

The aarch64-apple-darwin CSV and YAML native jobs built rapidyaml and the natives on a hosted
macos-15 runner, with only the remote cache to help; one hit the job timeout on a slow runner while
releasing 0.14.0. The organization's self-hosted macOS arm64 BuildBuddy executor (pool
komodo-release-macos-arm64) runs the same YAML tests in about 80 seconds.

--config=remote_macos targets //bazel/platforms:rbe_macos_arm64 with its own cache namespace, since
the macOS C/C++ wrapper selects the executor's SDK outside action keys. Trusted runs drive it from a
Linux runner; fork PRs, which get no BuildBuddy key, keep the hosted macOS runner and local builds.

Signed-off-by: Sam Gammon <sam@elide.dev>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment on lines +37 to +39
runs-on: ${{ matrix.remote && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && 'ubuntu-24.04' || matrix.runner }}
env:
BAZEL_CONFIG: ${{ matrix.remote && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && 'remote_macos' || 'local' }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Uncredentialed macOS checks lose local fallback

When neither optional BuildBuddy secret is set, BAZEL_CONFIG still selects remote_macos on a Linux runner. The explicit config overrides configure-buildbuddy.sh's local fallback, so both native checks fail without credentials.

Learn more

The reusable native workflow declares both BuildBuddy secrets optional. When neither is set, the credential setup writes a local Bazel configuration, but the macOS matrix still selects an Ubuntu runner and passes --config=remote_macos. A command-line config takes precedence over the fallback, leaving the build pointed at the remote executor without credentials. The two macOS jobs cannot run their native tests on that Linux runner.

Example: Run the CI workflow on main in a repository where neither BuildBuddy secret is configured. The CSV and YAML macOS jobs start on Ubuntu and invoke remote execution without a key; previously they started on macos-15 and ran locally.

Recommended fix: Gate both runs-on and BAZEL_CONFIG on the presence of a BuildBuddy key as well as the trusted-event condition, while keeping the secret out of logs and action environments.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed

codspeed Bot commented Nov 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 28 untouched benchmarks


Comparing ci/macos-rbe (736546c) with main (55de716)

Open in CodSpeed

@sgammon
Sam Gammon (sgammon) merged commit 7a0ee75 into main Nov 17, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant