Repository navigation
ci: run the macOS native checks on the self-hosted macOS executor - #124
Conversation
The aarch64-apple-darwin CSV and YAML native jobs built rapidyaml and the natives on a hosted macos-15 runner, with only the remote cache to help; one hit the job timeout on a slow runner while releasing 0.14.0. The organization's self-hosted macOS arm64 BuildBuddy executor (pool komodo-release-macos-arm64) runs the same YAML tests in about 80 seconds. --config=remote_macos targets //bazel/platforms:rbe_macos_arm64 with its own cache namespace, since the macOS C/C++ wrapper selects the executor's SDK outside action keys. Trusted runs drive it from a Linux runner; fork PRs, which get no BuildBuddy key, keep the hosted macOS runner and local builds. Signed-off-by: Sam Gammon <sam@elide.dev>
| runs-on: ${{ matrix.remote && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && 'ubuntu-24.04' || matrix.runner }} | ||
| env: | ||
| BAZEL_CONFIG: ${{ matrix.remote && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && 'remote_macos' || 'local' }} |
There was a problem hiding this comment.
🟡 Uncredentialed macOS checks lose local fallback
When neither optional BuildBuddy secret is set, BAZEL_CONFIG still selects remote_macos on a Linux runner. The explicit config overrides configure-buildbuddy.sh's local fallback, so both native checks fail without credentials.
Learn more
The reusable native workflow declares both BuildBuddy secrets optional. When neither is set, the credential setup writes a local Bazel configuration, but the macOS matrix still selects an Ubuntu runner and passes --config=remote_macos. A command-line config takes precedence over the fallback, leaving the build pointed at the remote executor without credentials. The two macOS jobs cannot run their native tests on that Linux runner.
Example: Run the CI workflow on main in a repository where neither BuildBuddy secret is configured. The CSV and YAML macOS jobs start on Ubuntu and invoke remote execution without a key; previously they started on macos-15 and ran locally.
Recommended fix: Gate both runs-on and BAZEL_CONFIG on the presence of a BuildBuddy key as well as the trusted-event condition, while keeping the secret out of logs and action environments.
Was this helpful? React with 👍 or 👎 to provide feedback.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Runs the
aarch64-apple-darwinCSV and YAML native checks on our self-hosted macOS arm64 BuildBuddy executor instead of building on a hostedmacos-15runner.//bazel/platforms:rbe_macos_arm64routes to the executor withOSFamily=darwin,Arch=arm64,use-self-hosted-executors=trueandPool=komodo-release-macos-arm64. The pool comes fromMY_POOLin the executor's launchd job.--config=remote_macosuses its own cache namespace (elide-dev/truffledata/macos/v1): the macOS C/C++ wrapper selects the executor's SDK outside the action keys, so these results must not share cache entries with Linux or with developer machines.--config=remote_macos. Fork PRs get no BuildBuddy key, so they keepmacos-15and--config=localrather than skipping the check.Why: on the 0.14.0 release commit, the hosted macOS YAML job hit the job timeout on a slow runner. Its rerun passed in under 5 minutes. The same YAML tests (
api_test,input_test,stream_test,yaml_archive_test) pass on the remote executor in about 80 s.Verified: those four YAML targets on the executor, driven from a Mac. Not yet verified: driving it from a Linux host, and the CSV and shared-loading/ThinLTO targets remotely. This PR's own CI run covers both.
🤖 Generated with Claude Code