Skip to content

fix(playback): prevent signed AWS/GCS stream URLs from reaching CORS proxies - #533

Merged
hoangsvit merged 2 commits into
stagingfrom
fix/proxy-signed-provider-queries-20261119
Nov 20, 2026
Merged

hoangsvit merged 2 commits into
stagingfrom
fix/proxy-signed-provider-queries-20261119

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

Reproduction / impact

buildPlaybackSources([{src:'https://radio.example/live.mp3?X-Amz-Signature=test'}], 'https://cors.example/') previously generated a proxy fallback containing the signed URL, exposing cloud-provider query credentials to the proxy. The existing token/accessKey guard did not match AWS X-Amz-*, Google X-Goog-*, AWSAccessKeyId, or GoogleAccessId.

Fix

Extend the existing signed-query guard narrowly to these cloud-provider fields. Preserve direct playback, ordinary non-HLS proxy fallback, explicit proxied sources and HLS behavior. No provider tokens included in the patch; test values are synthetic.

Regression / checks

  • Added regression test covering AWS SigV4, temporary session token, Google signed URL, legacy access identifiers, and normal quality=high fallback.
  • Reproduced the previous regex false-negative locally; 9/9 parameter-classification assertions pass with new expression under Node 22.16.0.
  • Full repository npm ci && npm test under required Node 24.15.0 and browser QA not run locally; CI must verify.

Risk and acceptance

  • Signed streams that require third-party proxying may no longer have that fallback; direct URL is preserved. Expected behavior is no signed query sent to the third-party proxy, while unsigned MP3 fallback continues.
  • Verify Node 24 CI and playback regression tests before review. No production deployment or release.

Base: staging at 01e9c1fe5cee7a00903fee179211bb6dfdca9ed8; independent fix branch.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

ePlus OnAir — PR Preview

🗃️ Preview expired. This PR is closed; the Preview link is hidden.

View build status

Preview is noindex; the full catalog is available on Staging after merge.

@hoangsvit
hoangsvit marked this pull request as ready for review November 20, 2026 01:43
@hoangsvit
hoangsvit merged commit cb59d47 into staging Nov 20, 2026
10 checks passed
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@hoangsvit
hoangsvit deleted the fix/proxy-signed-provider-queries-20261119 branch November 20, 2026 01:43

This branch was successfully deployed

1 active deployment
preview — 94b8a999 Deployed Nov 20, 2026 by hoangsvit via Remove closed PR Preview #542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant