Repository navigation
fix(playback): prevent signed AWS/GCS stream URLs from reaching CORS proxies - #533
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
ePlus OnAir — PR Preview🗃️ Preview expired. This PR is closed; the Preview link is hidden. Preview is noindex; the full catalog is available on Staging after merge. |
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Reproduction / impact
buildPlaybackSources([{src:'https://radio.example/live.mp3?X-Amz-Signature=test'}], 'https://cors.example/')previously generated a proxy fallback containing the signed URL, exposing cloud-provider query credentials to the proxy. The existing token/accessKey guard did not match AWSX-Amz-*, GoogleX-Goog-*,AWSAccessKeyId, orGoogleAccessId.Fix
Extend the existing signed-query guard narrowly to these cloud-provider fields. Preserve direct playback, ordinary non-HLS proxy fallback, explicit
proxiedsources and HLS behavior. No provider tokens included in the patch; test values are synthetic.Regression / checks
quality=highfallback.npm ci && npm testunder required Node 24.15.0 and browser QA not run locally; CI must verify.Risk and acceptance
Base: staging at
01e9c1fe5cee7a00903fee179211bb6dfdca9ed8; independent fix branch.