You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(report): expand partial station email template placeholders - #534
Call stationReportEmailUrl('/vn/ho-chi-minh/test-radio', 'Test Radio', 'Playback problem', 'Station: {station}'). Before this fix, the body retains literal {station} because expansion requires both{station} and {url}. The same happens to a URL-only localized template.
Expected / actual
Expected: replace any provided placeholder, include missing public station details once, never show raw placeholder markers. Actual: partial templates remain unexpanded and append duplicate details.
Fix
Recognize either placeholder, replace present tokens, append only missing public station fields. Preserve existing no-placeholder and full-template behavior, mailto encoding, and CRLF normalization.
Regression
Added partial-template cases to tests/station-sharing-mailto-line-endings.test.mjs for station-only and URL-only inputs. Local execution was not possible because repository clone was unavailable in this runtime; CI Node 24 npm test is required before review.
Acceptance
Both single-placeholder variants render correctly without literal tokens.
Existing full-placeholder and plain-text templates retain behavior.
npm test passes on CI.
Risk
Low: only changes fallback report-email body formatting; no playback, SEO, catalog, or deployment changes. No secrets or user data included.
Base: staging 01e9c1fe5cee7a00903fee179211bb6dfdca9ed8. Independent from #533.
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction
Call
stationReportEmailUrl('/vn/ho-chi-minh/test-radio', 'Test Radio', 'Playback problem', 'Station: {station}'). Before this fix, the body retains literal{station}because expansion requires both{station}and{url}. The same happens to a URL-only localized template.Expected / actual
Expected: replace any provided placeholder, include missing public station details once, never show raw placeholder markers. Actual: partial templates remain unexpanded and append duplicate details.
Fix
Recognize either placeholder, replace present tokens, append only missing public station fields. Preserve existing no-placeholder and full-template behavior, mailto encoding, and CRLF normalization.
Regression
Added partial-template cases to
tests/station-sharing-mailto-line-endings.test.mjsfor station-only and URL-only inputs. Local execution was not possible because repository clone was unavailable in this runtime; CI Node 24npm testis required before review.Acceptance
npm testpasses on CI.Risk
Low: only changes fallback report-email body formatting; no playback, SEO, catalog, or deployment changes. No secrets or user data included.
Base: staging
01e9c1fe5cee7a00903fee179211bb6dfdca9ed8. Independent from #533.