Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/radio-source-plan.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -148,3 +148,19 @@ test("does not disclose embedded stream credentials through a CORS proxy", () =>
]);
assert.equal(result.filter(item => item.proxied).length, 1);
});


test("never forwards signed query credentials to a third-party proxy", () => {
const sources = [
{ src: "https://radio.example/live.mp3?token=private-test-value" },
{ src: "https://radio.example/live.aac?accessKey=private-test-value" },
{ src: "https://radio.example/live.mp3?Signature=private-test-value" },
{ src: "https://radio.example/live.mp3?quality=high" },
];
const result = buildPlaybackSources(sources, "https://cors.example/");
assert.deepEqual(result.map(item => item.src), [
...sources.slice(0, 3).map(item => item.src),
"https://radio.example/live.mp3?quality=high",
"https://cors.example/https://radio.example/live.mp3?quality=high",
]);
});
5 changes: 4 additions & 1 deletion utils/radio-source-plan.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ export const buildPlaybackSources = (sources, corsServer) => {
let hasCredentials = false;
try {
const parsed = new URL(src);
hasCredentials = Boolean(parsed.username || parsed.password);
// Signed stream URLs must not be forwarded to third-party CORS proxies.
const sensitiveQuery = [...parsed.searchParams.keys()].some(key =>
/^(?:token|access[_-]?key|api[_-]?key|auth(?:orization)?|signature|sig|secret|password|jwt|expires?|policy|key[_-]?pair[_-]?id)$/i.test(key));
hasCredentials = Boolean(parsed.username || parsed.password || sensitiveQuery);
} catch { /* Invalid URLs are not eligible for proxy fallback. */
hasCredentials = true;
}
Expand Down
Loading