You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(playback): keep signed stream query credentials out of CORS proxy URLs - #532
buildPlaybackSources() previously blocked URL username/password from proxy fallback but forwarded query-based stream credentials (?token=, ?accessKey=, ?Signature=) to a third-party CORS proxy. Reproduced using a synthetic MP3 URL: the generated second candidate contained the private test token in the proxy URL. No live token or real stream was used.
Fix
Suppress automatic CORS-proxy fallback for sources with common signed/auth query parameter names. Preserve the direct source; ordinary unsigned MP3 streams retain proxy fallback. No HLS behavior change.
Added repository regression test in tests/radio-source-plan.test.mjs for token/accessKey/Signature and benign quality query.
Full npm ci, npm test, Nuxt build, and browser QA not run locally; require PR CI on Node 24.15.0.
Acceptance criteria
Signed query credentials never appear in automatically generated CORS proxy candidates.
Direct playback candidates remain unchanged.
Unsigned proxy fallback and HLS behavior remain unchanged.
Full test suite and CI pass.
Risk
Some providers using query-based authorization may lose an otherwise-working proxy fallback; direct playback is retained. This is intentional to avoid disclosure to third-party proxy infrastructure. The parameter list is heuristic and not a comprehensive secret detector. No secrets, deployment, or production branch changes.
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified issue
buildPlaybackSources()previously blocked URL username/password from proxy fallback but forwarded query-based stream credentials (?token=,?accessKey=,?Signature=) to a third-party CORS proxy. Reproduced using a synthetic MP3 URL: the generated second candidate contained the private test token in the proxy URL. No live token or real stream was used.Fix
Suppress automatic CORS-proxy fallback for sources with common signed/auth query parameter names. Preserve the direct source; ordinary unsigned MP3 streams retain proxy fallback. No HLS behavior change.
Tests
tests/radio-source-plan.test.mjsfor token/accessKey/Signature and benign quality query.npm ci,npm test, Nuxt build, and browser QA not run locally; require PR CI on Node 24.15.0.Acceptance criteria
Risk
Some providers using query-based authorization may lose an otherwise-working proxy fallback; direct playback is retained. This is intentional to avoid disclosure to third-party proxy infrastructure. The parameter list is heuristic and not a comprehensive secret detector. No secrets, deployment, or production branch changes.