Skip to content

fix(playback): keep signed stream query credentials out of CORS proxy URLs - #532

Merged
hoangsvit merged 2 commits into
stagingfrom
fix/prevent-signed-stream-proxy-leak-20261119
Nov 19, 2026
Merged

hoangsvit merged 2 commits into
stagingfrom
fix/prevent-signed-stream-proxy-leak-20261119

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

Verified issue

buildPlaybackSources() previously blocked URL username/password from proxy fallback but forwarded query-based stream credentials (?token=, ?accessKey=, ?Signature=) to a third-party CORS proxy. Reproduced using a synthetic MP3 URL: the generated second candidate contained the private test token in the proxy URL. No live token or real stream was used.

Fix

Suppress automatic CORS-proxy fallback for sources with common signed/auth query parameter names. Preserve the direct source; ordinary unsigned MP3 streams retain proxy fallback. No HLS behavior change.

Tests

  • Local Node 22 isolated reproduction/regression: 1/1 pass (synthetic signed/unsigned stream candidates).
  • Added repository regression test in tests/radio-source-plan.test.mjs for token/accessKey/Signature and benign quality query.
  • Full npm ci, npm test, Nuxt build, and browser QA not run locally; require PR CI on Node 24.15.0.

Acceptance criteria

  • Signed query credentials never appear in automatically generated CORS proxy candidates.
  • Direct playback candidates remain unchanged.
  • Unsigned proxy fallback and HLS behavior remain unchanged.
  • Full test suite and CI pass.

Risk

Some providers using query-based authorization may lose an otherwise-working proxy fallback; direct playback is retained. This is intentional to avoid disclosure to third-party proxy infrastructure. The parameter list is heuristic and not a comprehensive secret detector. No secrets, deployment, or production branch changes.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

ePlus OnAir — PR Preview

🗃️ Preview expired. This PR is closed; the Preview link is hidden.

View build status

Preview is noindex; the full catalog is available on Staging after merge.

@hoangsvit
hoangsvit marked this pull request as ready for review November 19, 2026 09:01
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@hoangsvit
hoangsvit merged commit 01e9c1f into staging Nov 19, 2026
10 checks passed
@hoangsvit
hoangsvit deleted the fix/prevent-signed-stream-proxy-leak-20261119 branch November 19, 2026 09:02

This branch was successfully deployed

1 active deployment
preview — 22db8531 Deployed Nov 19, 2026 by hoangsvit via Remove closed PR Preview #539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant