Repository navigation
#454 を実装する(スプリント m8d) - #486
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
takemi-ohama
marked this pull request as ready for review
October 14, 2026 01:09
This was referenced Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devbase envのシェル補完の候補にtokenとbackendのサブコマンドを足しました(#454)。あわせて、補完のサブコマンドの一覧が一致するかを一致テストで比べるようにし、そのことを確定仕様と CHANGELOG に書きました。利用者向けの変化
devbase envのシェル補完(bash・zsh)で、サブコマンドの候補にtokenとbackendが出る移行の手順
変更の要点
etc/devbase-completion.bashとetc/_devbaseの env のサブコマンドの一覧にtokenとbackendを足したtests/cli/test_name_context_consistency.pyの一致テストで、env のサブコマンドの一覧も比べるようにしたdocs/specifications/cli-argument-resolution.mdとCHANGELOG.mdに書いたテスト
設計と違う点
変えたこと
etc/devbase-completion.bashとetc/_devbaseのenv_subcommandsにtokenとbackendを足した。zsh の説明はlib/devbase/cli.pyの help に合わせたtests/cli/test_name_context_consistency.py)のサブコマンドの一覧の比較にenvを足した。envは[name]・--contextを取るかによらず、argparse のenvの直下のサブコマンド(今は 18 個)の全部が bash・zsh の両方の一覧にあることを確かめるdocs/specifications/cli-argument-resolution.mdの一致テストの表とCHANGELOG.mdの[Unreleased]に書いた手で確かめたこと
tokenを外すと一致テストが落ちる。bash と zsh の両方の一覧からtokenを外して-k lists_subcommandsを走らせた結果:AssertionError: etc/_devbase の env_subcommands に無い: ['token']AssertionError: etc/devbase-completion.bash の env のサブコマンドの一覧に無い: ['token']2 failed, 4 passed。元に戻して通ることを確かめたzsh -n etc/_devbaseが通るenv -u DEVBASE_ROOT python3 -m pytest -q tests/cliが全部通る(1070 件)。シェル補完が --context を open と post-start でしか出さない #435 の--contextの補完のテストも含む残した事項
devbase env backend <TAB>でstatus/useなどの下のサブコマンドを出す補完は範囲外として足していないモード: standard / 通した工程: 実装 → 完了判定 → Pull Request
🤖 Generated with Claude Code