Repository navigation
chore: promote the runtime surface at 1.0.14 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "deriv", | ||
| "version": "1.0.13", | ||
| "version": "1.0.14", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit · Codex release_notes still says 'First directory release.' The version moves to 1.0.14, but Suggestion: Update release_notes to describe the 1.0.14 changes in the next promotion. |
||
| "description": "Live Deriv API schemas, payload validation, and guides for authentication, subscriptions, trades, and errors.", | ||
| "author": { | ||
| "name": "deriv", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -157,6 +157,24 @@ server, so keep API tokens and other secrets out of tool-call arguments. | |
| When you build an integration that itself calls the Deriv API, your own | ||
| application supplies its own credentials. | ||
|
|
||
| ## Privacy | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit · Privacy section duplicates PRIVACY.md contact details The new Privacy section copies the policy URL and the DPO contact ( |
||
|
|
||
| The [Deriv Privacy Policy](https://deriv.com/privacy-policy) applies to | ||
| personal data processed through the plugin. See [`PRIVACY.md`](PRIVACY.md) for | ||
| what the plugin and the hosted server process. | ||
|
|
||
| For privacy questions or requests, contact Deriv's Data Protection Officer at | ||
| [dpo@deriv.com](mailto:dpo@deriv.com). | ||
|
|
||
| ## Support | ||
|
|
||
| - Questions and bug reports: | ||
| [GitHub issues](https://github.com/deriv-com/deriv-api-plugin/issues). | ||
| - Email: [api-support@deriv.com](mailto:api-support@deriv.com). | ||
|
|
||
| Report a suspected vulnerability privately, as [`SECURITY.md`](SECURITY.md) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit · Vulnerability-reporting route now described in three places The Support section's vulnerability sentence repeats the SECURITY.md bullet in 'Where to go next' and CONTRIBUTING.md's 'Reporting a security issue' section. Failure scenario: a change to the private disclosure process has to be made in all three places, or they will contradict each other. |
||
| describes, not in a public issue. | ||
|
|
||
| ## Where to go next | ||
|
|
||
| - [`CONTRIBUTING.md`](CONTRIBUTING.md) — how to file issues and open pull requests. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,8 @@ | |
| "$schema": "https://agent-plugins.org/schemas/1.0.0/plugin.schema.json", | ||
| "name": "deriv", | ||
| "description": "Live Deriv API schemas, payload validation, and guides for authentication, subscriptions, trades, and errors.", | ||
| "version": "1.0.13", | ||
| "author": { "name": "Deriv", "email": "api-support@deriv.com" }, | ||
| "version": "1.0.14", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit · Release still hand-edits eight version/ref lines Each promotion hand-edits six manifest versions and two marketplace refs (8 lines in this diff). Failure scenario: a missed one is caught only if verify-surface runs on that exact tree. Deriving all versions and refs from one value in the promotion build would remove this class of error. This lives in the private build tooling, so it's an optional improvement. Suggestion: Generate manifest versions and catalogue refs from a single source in build-promotion-bundle.mjs. |
||
| "author": { "name": "Deriv", "email": "api-support@deriv.com", "url": "https://developers.deriv.com" }, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit · author.url added only to the root plugin.json
Suggestion: Consider adding the same author.url to the other manifests that accept it, or pin it in verify-surface. |
||
| "homepage": "https://developers.deriv.com", | ||
| "repository": "https://github.com/deriv-com/deriv-api-plugin", | ||
| "license": "MIT", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit · Catalogue refs pin v1.0.14 before the tag exists
Both marketplace pins point at tag v1.0.14, but that tag is only created after merge (per the PR's 'After merge' step; this promotion is a manual PR, not the publish.yml run that cuts tags). Failure scenario: between merge and tagging, or if the tag step is skipped,
/plugin install deriv@derivandcodex plugin marketplace upgradecannot resolve the ref, and installs fail for every user. This is the documented process, so it's a nit, but the tag step must not be missed.Suggestion: Create the annotated v1.0.14 tag and the release immediately after merge, as the PR describes, and confirm both refs resolve.