Repository navigation
chore: promote the runtime surface at 1.0.14 - #16
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
ako-deriv
left a comment
There was a problem hiding this comment.
Automated review
✅ Approve — 6 nits
This is a clean promotion. All six manifests are at 1.0.14 in lockstep, and both catalogue refs point at v1.0.14, which satisfies the verify-surface.mjs pins. The new README Privacy and Support sections match PRIVACY.md, SECURITY.md and the manifests' supportUrl and author.email. Every finding is a nit. The main ones: the Codex release_notes still reads "First directory release", and the v1.0.14 tag has to be cut right after merge or Claude Code and Codex installs fail until it exists. Nothing blocks the merge.
Bugs
- Catalogue refs pin v1.0.14 before the tag exists
.claude-plugin/marketplace.json:15(nit)
Both marketplace pins point at tag v1.0.14, but that tag is only created after merge (per the PR's 'After merge' step; this promotion is a manual PR, not the publish.yml run that cuts tags). Failure scenario: between merge and tagging, or if the tag step is skipped,/plugin install deriv@derivandcodex plugin marketplace upgradecannot resolve the ref, and installs fail for every user. This is the documented process, so it's a nit, but the tag step must not be missed.
Suggestion: Create the annotated v1.0.14 tag and the release immediately after merge, as the PR describes, and confirm both refs resolve. - Codex release_notes still says 'First directory release.'
.codex-plugin/plugin.json:3(nit)
The version moves to 1.0.14, butextensions.com.openai.publication.release_notes(.codex-plugin/plugin.json:105, outside the diff) still reads 'First directory release. …'. Failure scenario: a resubmission or upgrade of the Codex directory listing at 1.0.14 shows notes for the first release rather than this one (README Privacy and Support sections, author.url). verify-surface only checks that the field is non-empty, so CI won't catch it.
Suggestion: Update release_notes to describe the 1.0.14 changes in the next promotion. - author.url added only to the root plugin.json
plugin.json:6(nit)
author.urlis added to rootplugin.jsononly. The Claude, Cursor, Kimi and Antigravity manifests still declareauthorwithouturl. Failure scenario: hosts reading those manifests show no author link while Agent Plugins v1 hosts do. verify-surface checks author.url only on the Codex manifest, so further drift has no CI signal. The spec scoped the change to the root manifest, so this is a nit.
Suggestion: Consider adding the same author.url to the other manifests that accept it, or pin it in verify-surface. - Privacy section duplicates PRIVACY.md contact details
README.md:160(nit)
The new Privacy section copies the policy URL and the DPO contact (dpo@deriv.com) from PRIVACY.md, and repeats the PRIVACY.md pointer already in 'Where to go next' (lines 181-182). Failure scenario: if the DPO contact or policy URL changes, one of README.md, PRIVACY.md or the Codex privacyPolicyURL is easily missed, and the public README gives wrong privacy-contact information. The spec deliberately adds a direct link for Kiro's submission check, so this is a nit. - Vulnerability-reporting route now described in three places
README.md:175(nit)
The Support section's vulnerability sentence repeats the SECURITY.md bullet in 'Where to go next' and CONTRIBUTING.md's 'Reporting a security issue' section. Failure scenario: a change to the private disclosure process has to be made in all three places, or they will contradict each other. - Release still hand-edits eight version/ref lines
plugin.json:5(nit)
Each promotion hand-edits six manifest versions and two marketplace refs (8 lines in this diff). Failure scenario: a missed one is caught only if verify-surface runs on that exact tree. Deriving all versions and refs from one value in the promotion build would remove this class of error. This lives in the private build tooling, so it's an optional improvement.
Suggestion: Generate manifest versions and catalogue refs from a single source in build-promotion-bundle.mjs.
Bug pass report (/review high)
I found 7 possible issues in 383f317..c9765c7. None of them breaks anything for certain.
The most serious is #1: the commit sets .agents/plugins/marketplace.json to v1.0.14, but the checked-out file still says v1.0.13, even though the worktree's HEAD is c9765c7. Bash was denied in this session, so I couldn't run git status or git show to tell whether that's an uncommitted local change or a stale checkout. Nothing was verified after dedup, as the high-effort recipe specifies. There is no repo-level CLAUDE.md, and the user-level one only covers the PR workflow, so the conventions check found nothing.
[
{
"file": ".agents/plugins/marketplace.json",
"line": 12,
"summary": "The checked-out file still pins ref \"v1.0.13\" while every manifest (including .codex-plugin/plugin.json) is now 1.0.14, so the Codex marketplace pin is out of lockstep with the version it should match.",
"failure_scenario": "The worktree at HEAD c9765c7 reads \"ref\": \"v1.0.13\", although the reviewed commit changes it to v1.0.14. If this tree is what gets checked or pushed, verify-surface.mjs (lines 691-701) computes expectedRef = \"v1.0.14\" from codex.version and fails with 'marketplace source must be the url pin at the lockstep version tag'. If it slips past CI, `codex plugin marketplace add` installs the old 1.0.13 surface. Check `git status` / `git show HEAD:.agents/plugins/marketplace.json`."
},
{
"file": ".claude-plugin/marketplace.json",
"line": 15,
"summary": "Both marketplace pins point at tag v1.0.14 inside the same commit that creates the 1.0.14 version, but only publish.yml cuts that tag. This commit looks hand-pushed, so the tag may not exist.",
"failure_scenario": "publish.yml commits with the message 'chore: promote runtime surface ${TAG}' and then runs `gh release create`. This commit's message is 'chore: promote the runtime surface at 1.0.14', which suggests a manual push. If tag v1.0.14 was never created on deriv-com/deriv-api-plugin, `/plugin install deriv@deriv` and `codex plugin marketplace upgrade` fail to resolve the ref, and installs break for every user until the tag is created."
},
{
"file": ".codex-plugin/plugin.json",
"line": 105,
"summary": "The version moves to 1.0.14 but extensions.com.openai.publication.release_notes still reads 'First directory release.', so the Codex directory listing carries stale release notes.",
"failure_scenario": "Resubmitting or upgrading the Codex directory listing at 1.0.14 shows reviewers and users notes for the first release rather than this one (which adds the Privacy/Support README sections and author.url). verify-surface only checks that release_notes is non-empty, so CI won't catch it."
},
{
"file": "plugin.json",
"line": 6,
"summary": "author.url is added only to the root plugin.json. The Claude, Cursor, Kimi and Antigravity manifests still declare author without url, so the same metadata now differs between hosts.",
"failure_scenario": "Hosts that read .claude-plugin/plugin.json, .cursor-plugin/plugin.json or kimi.plugin.json show no author link, while Agent Plugins v1 hosts reading the root plugin.json do. verify-surface checks author.url only on the Codex manifest, so the next edit can drift further without any CI signal."
},
{
"file": "README.md",
"line": 160,
"summary": "The new Privacy section copies PRIVACY.md (policy link and DPO contact) and repeats the PRIVACY.md and SECURITY.md pointers already in 'Where to go next' (lines 181-182).",
"failure_scenario": "The DPO address dpo@deriv.com and the privacy-policy URL now live in README.md, PRIVACY.md and the Codex privacyPolicyURL. If the DPO contact or policy URL changes, one copy is easily missed and the public README gives wrong privacy-contact information. A single pointer to PRIVACY.md would be enough."
},
{
"file": "README.md",
"line": 175,
"summary": "The Support section's vulnerability-reporting sentence repeats the SECURITY.md bullet in 'Where to go next' and the 'Reporting a security issue' section in CONTRIBUTING.md.",
"failure_scenario": "The vulnerability-reporting route is now described in three places (README Support, README 'Where to go next', CONTRIBUTING.md). Any change to the private disclosure process has to be made in all of them, or they will contradict each other."
},
{
"file": "plugin.json",
"line": 5,
"summary": "A release still means hand-editing the version in six manifests and two marketplace refs. CI only catches drift after the fact; there is no single source of truth that generates them.",
"failure_scenario": "Each promotion touches eight places by hand (this diff: 8 version/ref lines). A missed one (like the v1.0.13 ref in the checked-out .agents marketplace file) is caught only if verify-surface runs on that exact tree. Deriving all manifest versions and refs from one value in the promotion build would remove that whole class of error."
}
]Dropped by the main review: I dropped bug-pass #1 (".agents/plugins/marketplace.json still pins v1.0.13"). It is wrong: git show HEAD:.agents/plugins/marketplace.json reads "ref": "v1.0.14", and the PR diff changes v1.0.13 → v1.0.14. The v1.0.13 value the bug pass saw is only the working-tree copy of that agent-config file, which this review harness deliberately keeps at its merge-base version. The PR head is correct, and it satisfies verify-surface.mjs's expectedRef = v1.0.14.
Standards report
No hard violations; three minor judgement calls.
- verify-surface.mjs pins (K-003). All six manifests are at 1.0.14 (lockstep rule,
verify-surface.mjs~431-433 and 474-480)..agents/plugins/marketplace.jsonand.claude-plugin/marketplace.jsonboth pin"ref": "v1.0.14", which matchesexpectedRef = v${version}, and no keys were added..cursor-plugin/marketplace.jsonuses"./", so it needs no bump. The workflows are unchanged, so theverify-surface.ymlheader still describes what the checker enforces. - Root
plugin.jsonauthor.url. The checker does not inspect it;requireHttps('author.url')applies only to the Codex manifest. The value is https and equalshomepage, so it's fine. - CONTRIBUTING "focused on a single change" (judgement call). The commit bundles the version bump, the README sections and author.url. Under K-001 these are byte-for-byte promotions, so this is a nit at most.
- README
## Privacy/## Support. These are consistent with PRIVACY.md (the policy URL, the scope wording anddpo@deriv.com), the manifests'supportUrl/supportURLandauthor.email, and SECURITY.md plus CONTRIBUTING's private-disclosure rule. Style matches the file:##headings, ~80-column wrapping, backticked file links. Partial overlap with the "Where to go next" bullets is a judgement call; the bug pass covers it. - Outside the diff.
.codex-plugin/plugin.json:105release_notesstill reads "First directory release…". CI only requires it to be non-empty. It's a nit at most (covered by the bug pass). rules/deriv-api-conventionsdoes not apply to these files, and K-002'smcpServerspointer is untouched.
Spec report
No spec findings. Every claim checked against HEAD matches.
- (a) Missing or partial requirements: none.
- (b) Scope creep: none. Exactly 9 files are modified, with none added or deleted, in one commit. There are no MCP, rules, assets, skills or
.github/changes. - (c) Implemented but wrong: none.
How each claim checked out:
- "lockstep across all six manifests":
versionis 1.0.14 in.claude-plugin,.codex-plugin,.cursor-pluginand.antigravity-pluginplugin.json, inkimi.plugin.json, and in rootplugin.json. - "the scope PRIVACY.md states": PRIVACY.md lines 3-4 say the Privacy Policy "applies to personal data processed through the plugin". The README repeats both the URL and the wording.
- "dpo@deriv.com": it is on PRIVACY.md line 47.
- "the Claude Code listing's supportUrl":
.claude-plugin/plugin.json:12is the GitHub issues URL, and CodexsupportURLis the same. - "author.url is https://developers.deriv.com, the value the Codex manifest already carries": confirmed. Only that key is added, inside
author. - "catalogue source.ref move to v1.0.14": done in both marketplace files. "Cursor keeps source: "./"": confirmed.
- "two new sections before
## Where to go next, which is unchanged": confirmed.
Post-merge reminder: both catalogue refs point at v1.0.14, which won't exist until the annotated tag is created on the merge commit. This is the stated post-merge step.
Claude Code (claude-opus-5-5) · /review high bug pass · spec-review skill (Matt Pocock) · 7 learned review notes · reviewed c9765c7 against master · 3 min · $1.53 ($0.53 bug pass + $1.00 review) · triggered from Slack (message)
| "source": "url", | ||
| "url": "https://github.com/deriv-com/deriv-api-plugin.git", | ||
| "ref": "v1.0.13" | ||
| "ref": "v1.0.14" |
There was a problem hiding this comment.
nit · Catalogue refs pin v1.0.14 before the tag exists
Both marketplace pins point at tag v1.0.14, but that tag is only created after merge (per the PR's 'After merge' step; this promotion is a manual PR, not the publish.yml run that cuts tags). Failure scenario: between merge and tagging, or if the tag step is skipped, /plugin install deriv@deriv and codex plugin marketplace upgrade cannot resolve the ref, and installs fail for every user. This is the documented process, so it's a nit, but the tag step must not be missed.
Suggestion: Create the annotated v1.0.14 tag and the release immediately after merge, as the PR describes, and confirm both refs resolve.
| { | ||
| "name": "deriv", | ||
| "version": "1.0.13", | ||
| "version": "1.0.14", |
There was a problem hiding this comment.
nit · Codex release_notes still says 'First directory release.'
The version moves to 1.0.14, but extensions.com.openai.publication.release_notes (.codex-plugin/plugin.json:105, outside the diff) still reads 'First directory release. …'. Failure scenario: a resubmission or upgrade of the Codex directory listing at 1.0.14 shows notes for the first release rather than this one (README Privacy and Support sections, author.url). verify-surface only checks that the field is non-empty, so CI won't catch it.
Suggestion: Update release_notes to describe the 1.0.14 changes in the next promotion.
| "version": "1.0.13", | ||
| "author": { "name": "Deriv", "email": "api-support@deriv.com" }, | ||
| "version": "1.0.14", | ||
| "author": { "name": "Deriv", "email": "api-support@deriv.com", "url": "https://developers.deriv.com" }, |
There was a problem hiding this comment.
nit · author.url added only to the root plugin.json
author.url is added to root plugin.json only. The Claude, Cursor, Kimi and Antigravity manifests still declare author without url. Failure scenario: hosts reading those manifests show no author link while Agent Plugins v1 hosts do. verify-surface checks author.url only on the Codex manifest, so further drift has no CI signal. The spec scoped the change to the root manifest, so this is a nit.
Suggestion: Consider adding the same author.url to the other manifests that accept it, or pin it in verify-surface.
| When you build an integration that itself calls the Deriv API, your own | ||
| application supplies its own credentials. | ||
|
|
||
| ## Privacy |
There was a problem hiding this comment.
nit · Privacy section duplicates PRIVACY.md contact details
The new Privacy section copies the policy URL and the DPO contact (dpo@deriv.com) from PRIVACY.md, and repeats the PRIVACY.md pointer already in 'Where to go next' (lines 181-182). Failure scenario: if the DPO contact or policy URL changes, one of README.md, PRIVACY.md or the Codex privacyPolicyURL is easily missed, and the public README gives wrong privacy-contact information. The spec deliberately adds a direct link for Kiro's submission check, so this is a nit.
| [GitHub issues](https://github.com/deriv-com/deriv-api-plugin/issues). | ||
| - Email: [api-support@deriv.com](mailto:api-support@deriv.com). | ||
|
|
||
| Report a suspected vulnerability privately, as [`SECURITY.md`](SECURITY.md) |
There was a problem hiding this comment.
nit · Vulnerability-reporting route now described in three places
The Support section's vulnerability sentence repeats the SECURITY.md bullet in 'Where to go next' and CONTRIBUTING.md's 'Reporting a security issue' section. Failure scenario: a change to the private disclosure process has to be made in all three places, or they will contradict each other.
| "description": "Live Deriv API schemas, payload validation, and guides for authentication, subscriptions, trades, and errors.", | ||
| "version": "1.0.13", | ||
| "author": { "name": "Deriv", "email": "api-support@deriv.com" }, | ||
| "version": "1.0.14", |
There was a problem hiding this comment.
nit · Release still hand-edits eight version/ref lines
Each promotion hand-edits six manifest versions and two marketplace refs (8 lines in this diff). Failure scenario: a missed one is caught only if verify-surface runs on that exact tree. Deriving all versions and refs from one value in the promotion build would remove this class of error. This lives in the private build tooling, so it's an optional improvement.
Suggestion: Generate manifest versions and catalogue refs from a single source in build-promotion-bundle.mjs.
This PR promotes the runtime surface from the private working repo by copying files in. It was raised after a human approved the reviewed manifest (publication gate 2).
build-promotion-bundle.mjsbuilds the tree from the allowlist into an empty directory, so a path that is not on the allowlist never reaches the build. Every file in this branch is byte-identical to its source: 121 allowlisted paths and 4.github/scaffold files.Version 1.0.13 → 1.0.14, lockstep across all six manifests.
What changes
The README now carries a direct privacy policy link and a support contact, and the root
plugin.jsoncarriesauthor.url. These are what Kiro's powers submission checks for. Every value is already published elsewhere in this repo.README.md: two new sections before## Where to go next, which is unchanged.## Privacy: links the Deriv Privacy Policy with the scopePRIVACY.mdstates ("applies to personal data processed through the plugin"), points toPRIVACY.md, and gives the Data Protection Officer contact fromPRIVACY.md,dpo@deriv.com.## Support: the GitHub issues link (the Claude Code listing'ssupportUrl),api-support@deriv.com(author.emailin every manifest), and a pointer toSECURITY.mdfor suspected vulnerabilities.plugin.json:author.urlishttps://developers.deriv.com, the value the Codex manifest already carries. No top-level field is added.versionis 1.0.14, and the Claude Code and Codex cataloguesource.refmove tov1.0.14. Cursor keepssource: "./".PRIVACY.md,SECURITY.md,CONTRIBUTING.md,LICENSE, the rules, the assets, the skills, and every other manifest field. No path is added or removed.Surface checker
.github/is byte-identical tomaster, so this PR is one commit. The checker onmasteralready accepts this tree.Manifest
125 paths = 121 allowlisted + 4 scaffold, the same path set as
v1.0.13. 9 files change: none added, 9 modified, none deleted.verify-surface.mjspasses locally on this branch:OK — 125 path(s). The hosted MCP build pin check (mcp-build-pin.mjs) printsOKagainst a productioninitializecaptured fromhttps://mcp-api.deriv.com/mcp(serverInfo.name: deriv-api).After merge
In the same session, create the annotated tag
v1.0.14on the merge commit and the GitHub Release, so both catalogue refs resolve.🤖 Generated with Claude Code