refactor(recording): use session-bound control commands - #135
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bc114f4a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24b2667b02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
PASS. Independent shipping verification of PR #135. Verified head I did not implement this patch. I compared the previous toggle command and frontend stop coordination with the explicit controls, then traced the recording owner handshake, immutable start/stop/cancel receipts, token-scoped signal writes, exact-token legacy reads, atomic status identity, and frontend observation ordering. No blocking finding. Fresh verification at this head:
The process check uses fixture audio and a controlled speech executable. It verifies real process coordination and persistence, not microphone hardware or transcription accuracy. Prove It Works shaped this check by exercising owner/requester processes rather than relying on CI status alone. |
08e853e to
2c9ab89
Compare
Why
A recording toggle did not identify which session or operation a caller intended. Capture-stop and transcription cancellation shared one file, and the UI reconstructed stop progress from later polls.
Scope
Tradeoffs
The explicit protocol adds backend types and regression coverage. It removes ambiguous stop/cancel behavior and frontend reconstruction of whether a stop was accepted. No daemon, additional speech engine, or new runtime dependency is introduced.
Blast Radius
This changes recording control and status across Rust, Tauri, and React. The existing kernel-backed recording lease, private file handling, injection, and history persistence remain in use. This PR is stacked on #134.
Verification
The final combined suite is also checked with the settings child PR. Local full Rust tests use two test threads; hosted CI runs independently.