Centralize desktop settings and microphone ordering - #136
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 416ebceac0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
08e853e to
2c9ab89
Compare
|
@codex review |
|
PASS — independently verified the frozen head
No shipping blocker found in this unit. Boundary: this verdict does not replace review of the recording-base PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 246d03e977
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
246d03e to
7582fb6
Compare
2 participants
Settings and microphone operations currently coordinate through several frontend and backend queues and revision schemes. This change gives desktop configuration one backend FIFO owner. Each read or write returns its own revisioned snapshot, so a delayed response cannot overwrite newer settings in Home or Settings.
Synchronous Tauri command acceptance enqueues work before asynchronous dispatch. Typed completion channels preserve the frontend Promise API. Tray language changes and setup configuration changes use the same owner. The replaced frontend write chains, microphone queue, backend write lock, retry scheme, and tray language queue are removed.
PRs #134 and #135 have merged. Review this final PR against
main.Validation includes 272 frontend tests, six browser tests, frontend build/typecheck/lint, 513 passing Rust workspace tests under Xvfb with two test threads (16 ignored), Clippy, formatting, and generated IPC checks. A native WebKit/Tauri probe uses the production adapter and real completion channels to verify cross-domain ordering, saved values, error recovery, recording completion, and History retrieval.
The architecture documentation now describes these ownership boundaries. Research scripts remain because their audit found maintained consumers and explicit retention history. This change concentrates coordination; it adds backend protocol and test code while removing distributed state management.
Independent read-only review passed the settings unit. The final native probe passed against commit
416ebce, including stale recording-request rejection. Hosted checks are tracked on this PR.Release preparation updates the workspace and six local lockfile packages to 0.14.17 and adds changelog notes. The annotated release tag will be pushed only after this stack has merged and main builds pass. The queued setup cancellation review finding is fixed in 5397942 with a blocked-queue regression.