Repository navigation
fix(umami): silence expected connection failures when Umami is unreachable - #107
Closed
danielheene wants to merge 1 commit into
Closed
danielheene wants to merge 1 commit into
danielheene wants to merge 1 commit into
Conversation
…hable In E2E and test environments NEXT_PUBLIC_UMAMI_URL points to localhost:3002 which does not exist. Catch the upstream fetch error in the /stats proxy route and return 204 silently. Remove console.error calls from UmamiWidget.data.ts login/verify/fetch paths — the widget already handles null returns gracefully so the errors were pure noise with no actionable information.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by free · Input: 164.3K · Output: 1.8K · Cached: 51.8K |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/stats/[...path]proxy route and return 204 silently — in E2E/test environmentsNEXT_PUBLIC_UMAMI_URLpoints tolocalhost:3002which doesn't exist, so the ECONNREFUSED was expected noiseconsole.errorfromUmamiWidget.data.tslogin/verify/fetch paths — the widget already handlesnullreturns gracefully, the errors had no actionable information and flooded E2E logs