Repository navigation
fix(deps): use host-provided optional peer dependencies - #57
Open
ObsidianArch02 wants to merge 1 commit into
Open
ObsidianArch02 wants to merge 1 commit into
ObsidianArch02 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pi reports a startup warning because this extension installs
typeboxas a runtime dependency. A physical host-module copy can bypass Pi's extension module mapping and create duplicate runtime instances.typeboxas*peers, as required by Pi's package contract. Mark these peers optional so npm does not automatically install a separate host. Keep pinned copies in development dependencies for standalone tests and type checking.npm install --omit=dev --legacy-peer-depsand correct the Unreleased notes.Closes #58.
The same warning is reported in parallel-npm-packages#64 and wherever#68.
Verification
bun install --frozen-lockfile --ignore-scriptsbun run checkandbun run test: 104 tests pass.npm ci --ignore-scripts --no-audit --no-fund,npm test, andnpm run check: 104 tests pass.npm pack --dry-run --ignore-scripts: eight package files, no bundled host modules.npm ci --omit=dev --legacy-peer-deps --ignore-scriptsand manifest-onlynpm install --omit=dev --ignore-scripts: each installs onlydiff, with no Pi or TypeBox copies.apply_patchregisters, and file addition and update both produce the expected contents. No model API call is needed for this check.git diff --checkLocal environment: macOS, Node 26.9.0, npm 11.19.1, Bun 1.4.2. Development SDK versions remain 1.0.4. No resolved npm package versions, URLs, or integrity values changed, and Bun's package graph is unchanged. CI provides the repository's Node 22 and 24 coverage.
apply_patch impact
[Unreleased].Wildcard peers let the running Pi host provide its own modules without a competing version constraint. The previously tested 0.87.1 host remains documented. This packaging fix does not claim compatibility with arbitrary future breaking API changes.