Repository navigation
fix(app): the sign-in, the mailboxes page, the top bar, the list, the search and the open message use Kumo's controls, keeping their look - #98
Conversation
…s button "Use a recovery code instead", and "Use a code from the app instead", is an action, so it is Kumo's Button: the ghost kind, at the form's own size and across its width, under Continue. The controls check's debt loses SignInSteps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
Signing out is an action, so it is Kumo's Button at the small size, after the address and the link to sign-in and security, instead of a word underlined in the middle of the sentence. The controls check's debt loses home.tsx. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
|
audit: not passed yet, at I opened this branch from the local ref before it was pushed and measured each screen at 1280 px and 375 px. The note is on the issue: #82 (comment) Before merge:
To decide in this pull request: the quick filters' height (26 → 20 px), how Unsubscribe reads as an action, and the reason the sender's picture stays on purpose. Not opened by me: the sign-in's second step (the example has no two-step account); its picture is wanted here. I open the fixed screens again before passing. |
|
audit: one more before merge, and it is one I let through in my first note. The project lead saw it in the running app.
A rule for the rest of #82, which I am adding to the issue: a move to Kumo does not change what a screen looks like unless the pull request says so and shows it; where the skill describes a control, the description is not edited to fit the move. |
…umo's buttons inside it The search box stays the field it is: one wide box 48 px tall, fully round and filled, with no line, that turns to the page's colour with a ring when it has focus. Kumo 2.18.1's Input and InputGroup give a size alone, 40 px at their largest, with Kumo's corner and line, and a height, a corner or padding written by hand is refused; so the field is one ON_PURPOSE line that says what Kumo lacks. Its two buttons, "Clear search" and "Search options", are Kumo's: the ghost kind, round, at the small size, where they stood. The shade behind the rail on a phone stays a native button, as one ON_PURPOSE line with its reason: it is the screen around the rail, out of the tab order, and closes the rail when pressed. The controls check now holds InputGroup and its parts as it holds Kumo's other controls, so a size written by hand on one is refused; two cases in its tests, which fail without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
…n purpose The box above the list is Kumo's Checkbox, which says "some" with its own indeterminate state instead of a property set on the element after each paint. A line's box is Kumo's Checkbox too, and its star Kumo's Button, the ghost kind, square, at the small size: 26 px, no smaller a target than the 20 px the star had. Shift still ticks every line from the last box used: Kumo's box takes no click handler, so the line reads Shift from the click or the key that passes through it on the way to the box. Kumo's box takes clicks 12 px around itself, so the box above the list keeps that room from the menu's button beside it, which it covered. A line itself stays one native button, as one ON_PURPOSE line with its reason: it is the conversation, with who wrote, the subject, the text, its labels and the date, laid out for the width of the list, and Kumo's Button holds a label and an icon in one row. The browser tests find these boxes by role and name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
ac6c562 to
d3496fe
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
|
audit: not passed, at Fixed, by measurement
Before merge
To decide here
Accepted as changes of look: Sign out as a small button on the mailboxes page (the line is 26 px, was 15.3); the picture's initial at 14 px. Not opened by me: the sign-in's second step; its pictures are read from the From now on I compare each control with |
|
audit, from the pictures on the On the count of the debt: 43 on |
…pose Each quick filter above the results is Kumo's Button at the small size, 26 px as the chips were, which still says whether it is on with aria-pressed: on, it is the primary kind; off, the outline kind. They stay fully round, as before and as the folder's label in a result's line is. The controls check's debt loses search-results.tsx. Kumo's Button is round only as a circle for an icon alone, and the check refused a corner written by hand on a Kumo control. It now lets one shape through where it is listed: a Kumo control made fully round with rounded-full and nothing else written by hand, at a place of ROUND_ON_PURPOSE with its reason, the count exactly as listed. Padding beside the corner, another corner, a breakpoint, the important mark or a style attribute are still refused there; its tests say so, and fail without the exception. docs/status.md and the podbay-ui skill name the list, and the skill says that a move to Kumo keeps what a screen looks like. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
…ns, and its head stays on purpose Reply, Reply all and Forward under the last message are Kumo's buttons and stay fully round, as before: one line of ROUND_ON_PURPOSE with its reason. The controls check's SIZED_BY_HAND loses EmailPanel. "Unsubscribe" is Kumo's ghost button at the extra small size, grey and underlined, the text action it was. Its margins give back the 4 px it is taller than the name's line and the 6 px of its padding, so the head keeps the size it had and the word stands 8 px after the name, as it did. The head of a message stays as it was: the sender's picture, the sender's name and the line of who it went to, as a pair of lines 13 and 12 px beside the 40 px picture, the same in every message of a conversation. Each is one ON_PURPOSE line with what Kumo's Button cannot be there: the picture's own colours (Kumo's Button sets its text colour with an important mark and its own background under the pointer), and a line of text (Kumo's Button is a box of 20 px or more with its own padding). The name's line wraps. With the head laid out as it was, a mailing list's long sender beside Unsubscribe was drawn 0 px wide on a phone, so the browser test found it hidden. Unsubscribe now moves under the name when both do not fit. A browser test at phone width with such a sender holds that the name is cut, is shown, keeps its line above Unsubscribe and ends before the date; it fails without the wrap. The line of a folded message and the line that stands for the middle of a long conversation stay native too, each as one ON_PURPOSE line with its reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
d3496fe to
99d633d
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
|
audit: at Fixed, by measurement (this head =
Left
Accepted changes of look, as said in the description: Sign out as a small button; the search box's buttons at 26 px; the star at 26 px with the sender's column 6 px to the right; Unsubscribe's taller target. Not opened by me: the sign-in's second step (the example has no account with a second step); finding 8 is read from the pictures and from Kumo's own classes. |
Part of #82: six screens, one commit each, each lowering its own debt in the controls check. These are the screens a person meets first, as the order on #82 puts them. A move to Kumo keeps what a screen looks like, compared with
main; where Kumo cannot give the shape, the control stays as it was, with its reason.TO_MOVEgoes from 43 places to 26, the counts in its entries summed onmainand on this head.SIZED_BY_HANDgoes from 6 to 3.ON_PURPOSEgoes from 1 line to 9.ROUND_ON_PURPOSE, has 2 lines.The commits
Button, the ghost kind, across the form's width under Continue.Buttonat the small size, after the address and the "Sign-in and security" link.main, oneON_PURPOSEline naming what Kumo lacks.ON_PURPOSEline.InputGroupand its parts to Kumo's sizes.Checkbox.Button: ghost, square, small, 26 × 26.ON_PURPOSEline.Buttonat the small size, 26 px, and stay fully round.ROUND_ON_PURPOSE: a Kumo control made fully round withrounded-full, and nothing else written by hand, at a listed place with its reason and exact count.docs/status.mdand the podbay-ui skill name the list. The skill also says a move to Kumo keeps what a screen looks like.ROUND_ON_PURPOSEline.main: the picture, the name and the line of who it went to. Each is oneON_PURPOSEline saying what Kumo'sButtoncannot be there:Buttonsets its text colour with an important mark and its own background under the pointer;Buttonis a box of 20 px or more with its own padding.main's layout, a mailing list's long sender beside Unsubscribe was drawn 0 px wide on a phone, and the browser test found it hidden. Unsubscribe now moves under the name when both do not fit.test/e2e/reading.spec.tschecks four things at 375 px: the name is cut, it is shown, it keeps its line above Unsubscribe, and it ends before the date. It fails without the wrap.ON_PURPOSElines.Your findings
main. The initial isoklch(0.97)on the brand colouroklch(0.5772 0.2324 260). Under the pointer it keeps both colours and takes a ring.main, the same in every message. At 1280 px:ROUND_ON_PURPOSE.main's layout the name had no room at all there.Measurements on this head
Throwaway instance, at 1280 and 375 px.
Checks
pnpm checkpassed: 22 static checks, 1,017 unit tests.pnpm e2epassed, 92 tests.node scripts/commits.ts: six commits, no problems.Failed runs on this work before this head:
pnpm e2efailed one test at the first draft: the box above the list covered the menu's button.pnpm checkfailed once, on formatting.test/unit/controls.test.tsfailed one test while the new list was being placed: a test called the check without it. It now passes an empty list.main's head layout, it found the name hidden.CI: run 44476080477 on ac6c562 passed, and 44481251919 on d3496fe passed. The run on this head is pending.
Pictures
On the orphan branch
pictures, inpr-98/at 4361d92. All 40 are from a throwaway local instance with made-up mail, each under 80 KB.1. The sign-in's second step
2. The mailboxes page
3. The top bar, without focus
3. The top bar, with focus and text
4. The list, two lines ticked and one starred
5. The search, two quick filters on
6. A conversation that ends with one's own message
6. The same, the pointer on one's own picture
6. A mailing list's message, details shown
6. A message from a long sender
🤖 Generated with Claude Code