Skip to content

The app builds its form controls by hand beside Kumo's #82

Open

Description

@Madraka

Reported by the project lead on 2026-11-19 from the settings screen, and measured on main 6139942.

The app uses ten of Kumo's components (Button, Input, LayerDialog, DropdownMenu, Badge, the toast, Tooltip, Loader, Empty, Banner). Every other control is written by hand as a native element with its own classes, although Kumo 2.18.1, the version pinned here, exports Select, Checkbox, Radio, Switch, Field, Label, Textarea, DatePicker and Combobox.

What is there today

Written by hand Where
<select>, 9 settings/GeneralSettings.tsx, rules/FilterDialog.tsx (2), SearchOptions.tsx (2), AccessKeys.tsx (2), InvitePerson.tsx, routes/members.tsx
<input type="radio">, 35 on the general settings alone settings/Row.tsx and its callers
<input type="checkbox">, 11 the list, its toolbar, the filter dialog, the automatic reply, search options, others
<textarea>, 3 settings/AutoReplySettings.tsx, settings/AssistantSettings.tsx, AgentPanel.tsx
<input type="date"> and datetime-local, 5 search options, send later, the automatic reply
<button>, 28 to be read one by one: a line of the list is a real button on purpose; the others need a reason

What a person sees

  • The page-size select ("Conversations on a page"): the browser's own arrow, 12 px from the border because the control has the same padding left and right; the browser's focus colour, not the app's; 36 px high with 13 px type beside Kumo inputs of 26 px and 12 px.
  • Radios and checkboxes in the browser's blue and square corners, in both themes.
  • Dates in the browser's own picker, which differs by browser and ignores the app's language.

Done when

  • Every control in the table is Kumo's component, or stays native for a reason written at the place.
  • Where Kumo's component cannot do what is needed, one wrapper lives in one place under app/components/ and every screen uses it; no screen styles a native control itself.
  • The name and the role of each control stay what the browser tests find today, or the tests change in the same pull request.
  • Each changed screen is looked at in a real browser at desktop and phone width, in the light and the dark theme, and the pull request shows the pictures.
  • Kumo's own guidance for each component is read from its current documentation before it is used, and anything the code relies on about it is said in the pull request.

The check that keeps this from coming back is its own issue.

Activity

  1. added
    bugSomething isn't working
    area: appThe single-page app under app/
    on Nov 18, 2026
  2. Madraka commented on Nov 19, 2026

    @Madraka
    ContributorAuthor

    audit: findings on the first six screens of this issue, read at ac6c562 on the branch fix/kumo-first-screens (not pushed when I read it; this note moves to the pull request when it opens).

    Each screen was opened on an example instance at 1280 px and at 375 px, and measured. pnpm static passes (22). The debt goes from 46 places to 26, with six kept on purpose.

    To put right before it merges

    1. The sender's name in an open message no longer shortens. Kumo's Button is w-max shrink-0, so the min-w-0 on it and the truncate inside it do nothing. At 375 px the button is 137.3 px wide in a column of 102.9 px: the name ends at x = 181.3 and the date begins at 182.9, so they touch, and a longer name runs under the date and the three buttons beside it. On main the name is cut with an ellipsis. I want a browser test at phone width with a long sender, and the picture.
    2. The star in the list is a target of 14 × 14 px. size="xs" with shape="square" gives 14 px; the 16 px icon is drawn 14 px wide in it. On main the target is 20 × 20. The box beside it takes clicks 12 px around itself, so its target (40 × 32) ends exactly where the star's begins (x = 44 at 375 px, 301 at 1280 px): on a phone a slip from the star ticks the box. The target must be no smaller than it was; Kumo's sm is 26 px and the line is 48 px tall. The columns of the list must still line up afterwards, measured.

    Smaller, to decide in the same pull request

    1. The quick filters of a search went from 26 px to 20 px tall (size="xs"). sm keeps the size they had.
    2. "Unsubscribe" reads as a caption now: grey text, no underline, no border, 20 px tall, beside the name. On main it is underlined. Read Kumo's registry for what it gives a text action, and say which was chosen.
    3. The sender's picture kept on purpose (MessageHeader.tsx): the reason says Kumo's Button cannot be that picture. Say why shape="circle" at the 40 px size cannot, or move it.

    Holds, by measurement

    • Mailboxes page: Sign out is Kumo's sm (26 px), centred on the line of text beside it (117.0 against 117.1); at 375 px the line wraps without a sideways scroll.
    • Top bar: 64 px, the search group 40 px with 12 px above and below, both of its buttons 36 px, Clear appears with the first letter, focus ring is Kumo's.
    • List toolbar: the box's target ends where the menu's button begins (x = 46 at 375 px) and does not cover it.
    • Open message: the name's text and the recipients' text start at the same x (333 at 1280 px, 68 at 375 px); the three answers are 36 px with Kumo's corner.
    • The other four reasons in ON_PURPOSE (the line of the list, the folded message, the middle of a long conversation, the shade behind the rail) say what Kumo's Button cannot be there, and I accept them.

    Not opened

    • The second step of sign-in: the example instance has no account with two-step sign-in. Read in the diff only; its picture is wanted in the pull request.
  3. Madraka commented on Nov 19, 2026

    @Madraka
    ContributorAuthor

    Measured before the next screens move (the writing window, the address field, the answer under a conversation, attached files), at ac6c562, whose copies of these files are the same as on main. So that a move that makes something smaller is seen, as with the list's star:

    Place 1280 px 375 px
    The window's buttons (minimise, enlarge, save and close) 28 × 28 each, 2 px apart only save and close shows, 28 × 28
    The line of recipients 39.3 tall; the field in it 31.3; 13 px type 65.3 tall: the address sits on a first row, the field under it
    A recipient's address 22 tall the same
    The button that removes a recipient 14 × 14 14 × 14
    Cc Bcc 55.4 × 15.3, 13 px type the same
    Subject 31.3 tall, its text begins at the same x as the window's inner edge (633) 31.3 tall
    The bar of the editor every button 26 × 26 (already Kumo's) the same, on two rows
    Send / Send later / the icons 36 / 26 / 26 tall the same
    An attached file under a message 34 tall not measured

    What the move should not keep as it is:

    • The button that removes a recipient is a 14 × 14 target at both widths, the same size the list's star fell to. It should come out larger, not equal.
    • Cc Bcc is a 15 px tall target.
    • The row under the text does not fit a phone in Turkish and Delete is off the screen; that one is written up on The phone layout: what is left #52.

    Not opened: the answer under a conversation (the example opens answers in the window), a file that asks before it opens, a picture among the attached files, the list of scheduled messages. Their pictures are wanted in the pull request that moves them.

  4. Madraka commented on Nov 19, 2026

    @Madraka
    ContributorAuthor

    A rule for every move under this issue, after the top bar's search box (see the third finding on #98):

    A move to Kumo keeps the screen. Where the skill describes a control (its size, its shape, its fill), that description is what the move has to give, and it is not edited to fit the component. Where Kumo has no such shape, the control stays on purpose with a reason that names what Kumo lacks, and the gap is written down so it can be raised with Kumo. A change of look that is wanted is said in the pull request, with a picture before and after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: appThe single-page app under app/bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions