Repository navigation
build: every version lives in the workspace's catalog, and the checks read every package - #96
Conversation
… read every package ADR-0018, step 1 (decision 4). The 51 versions move from package.json into the catalog of pnpm-workspace.yaml, and package.json names each as "catalog:". No version changes: every catalog entry of the lockfile resolves to exactly its version, and the install fetched nothing. - scripts/pins.ts reads the workspace (scripts/workspace.ts, line by line, refusing a shape it does not read) and every package of it: a package takes its versions from the catalog or from the workspace, the catalog holds exact stable versions, a 0.x one needs its dated exception. - pinExceptions stays in the root package.json: a pnpm the project pins refuses a setting it does not know in pnpm-workspace.yaml (ERR_PNPM_UNRECOGNIZED_WORKSPACE_SETTINGS). - pnpm static licences lists every package (-r); without it pnpm lists the root's dependencies alone. - Biome turns a domain of rules on by itself only for a dependency with a version, so with "catalog:" six domains went quiet. biome.json names them, and pnpm static schemas keeps them in step with the catalog, and reads Biome's version from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
|
audit: pass, once the required checks are green Read at d7d9e73. No version changed. I compared the catalog with the pins of The checks read every package.
Two findings of the builder's that the record did not expect, both handled rightly:
Not proven until it happens: that Dependabot updates a catalog entry in this repository, with its groups and its ignore entry. The builder read that it does and that one open defect ends in a red pull request, not in silence. The first update it offers after this merges is read with that in mind; if a week passes with none while updates exist, that is the sign. Merge with a merge commit, and name the branch's runs. |
ADR-0018, step 1 of the move: decision 4's first bullet. No file of
app/,workers/orshared/moves, and no second package is created.What changes
The catalog. The 51 versions move from
package.jsonintocatalog:inpnpm-workspace.yaml, andpackage.jsonnames each as"catalog:".pnpm installresolved 0, reused 556 and downloaded 0. The lockfile diff removes 51 exact specifiers and adds thecatalogs:section and 51'catalog:'specifiers, nothing else.scripts/pins.tsreads the workspace and every package in it, throughscripts/workspace.ts. That reader goes line by line, and refuses a shape it does not read, such as a named catalog,catalog: { … }, or an indent it does not know. The rules:catalog:, orworkspace:for a package of the workspace;--resolveand--outdatedread the catalog.pinExceptionsstays in the rootpackage.json. ADR-0018 says it moves with the versions, but that is not possible. With the project's pnpm pinned (packageManager),pnpm installrefuses an unknown setting inpnpm-workspace.yamlwithERR_PNPM_UNRECOGNIZED_WORKSPACE_SETTINGS. A throwaway workspace without the pin accepted it silently, which is why I first thought it would work. The reader takes the exceptions from the root manifest.pnpm static licencesrunspnpm licenses list --json -r.Something the move would have broken silently, found by the lint ratchet.
react:>=16.0.0")."catalog:"there is no version, so all six domains that applied onmainwent quiet: drizzle, playwright, react, tailwind, tanstackQuery and test. It showed only because 19biome-ignorecomments for React'suseExhaustiveDependenciesbecame unused.biome.jsonnow names the six underlinter.domains.pnpm static schemasreads Biome's version from the catalog, and refuses a catalog entry that would turn a domain on whenbiome.jsondoes not name it, using Biome's own table of triggers.The three questions, settled from current sources
Dependabot and a pnpm catalog: yes.
ignorego by dependency name, so ours apply as before.--frozen-lockfile, that would be a red pull request, not updates stopping silently. #16766: a catalog split across files withincludeis not read; we have one file.pnpm licenses listand workspace packages: only with-r. In a throwaway workspace (pnpm 12.10.1, local folders, nothing fetched), the second package's dependency declared GPL-3.0-only. Without-rthe listing had only the root's MIT dependency; with-rit had both. The test below is that workspace.The three-day rule and a catalog entry: it holds. In a throwaway workspace with
minimumReleaseAge: 4320:@cloudflare/workers-types: 5.20261118.1(published 2026-11-18T01:04Z) was refused withERR_PNPM_NO_MATURE_MATCHING_VERSION;5.20261115.1, nearly four days old, installed.This was one read of the public registry; nothing was published.
Tests
test/unit/pins.test.ts, 23 tests: the catalog's forms; a second package that writes^2.0.0,2.0.0orlatestof its own; an entry missing or unused;workspace:for a stranger; 0.x without an exception; the reader's refusals; and a fixture workspace on disk whose second package is found and refused. With the check reading only the root, 5 of them fail.test/unit/licences-workspace.test.ts, 2 tests: the throwaway workspace installed offline from local folders. The check refuses the second package's GPL dependency, and pnpm without-rlists the root's alone. Without-rin the check, the refusal test fails.test/unit/schemas.test.ts, 9 tests: the version read from the catalog, and the domains named or refused.Locally,
pnpm checkpassed with 22 static checks and 1,007 unit tests. The browser suite was not run locally: no file of the app changed, and CI runs it.Records
AGENTS.md(rule 1), V1 in the engineering rules, the change skill's table, B9 in the security skill, anddocs/status.md(the pins, licences and schemas rows).🤖 Generated with Claude Code