Skip to content

fix(app): the settings, the filter dialog, the automatic reply, Send later and the search options use Kumo's controls - #97

Merged
Madraka merged 7 commits into
mainfrom
fix/kumo-controls
Nov 19, 2026
Merged

Madraka merged 7 commits into
mainfrom
fix/kumo-controls

Conversation

@Madraka

@Madraka Madraka commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Issues #82 and #83, for the screens the lead named and the screens that share the date field: one screen, or the one shared wrapper, in each commit. Each commit carries its test changes and lowers its own lines of the controls check's debt. Rebased on main at 249c3d7 (#96): no conflict, and nothing moved in the check's lists or the tests.

The commits

  1. General settings (39fc45a). The page-size select becomes Kumo's Select. All 35 radios become Kumo's Radio.Group, through Choice in settings/Row.tsx, with the legend kept for assistive technology. The tab's button uses the default size.
  2. The filter dialog (01f7bff). The two "contains / is exactly" selects and "Where it goes" become Select, and the checkboxes Checkbox. "The sender" and "A recipient" now stand at the row's left edge, above both the comparison and the field, as you asked; the field is named by htmlFor. Also in this commit, a fix: a Select's list opened under the dialog, whose wrapper took the click (app/index.css, see below).
  3. The automatic reply (ef6892c). The on/off box becomes Checkbox, the subject Input at its column's width, and the message InputArea, which grows from eight rows. "Save automatic reply" stands in the column of the fields.
  4. One date field (7aecbe0). Kumo 2.18.1 has no field for a date and a time; its DatePicker is a calendar only. app/components/controls/DateTimeField is the one place the browser's own field stands, drawn once at Kumo's default size with Kumo's Label above it. It is the controls check's one ON_PURPOSE line, with that reason. The automatic reply's "Starts" and "Ends" use it. Its limit is written in the file: the date shows in the device's form and language.
  5. Send later (5d723bf) uses DateTimeField, for "Change the time" as well.
  6. Search options (10b6763). "Label" and "Search in" become Select, "After" and "Before" DateTimeField with kind="date", and the two checkboxes Checkbox.

The debt goes from 62 places to 46. ON_PURPOSE has one line.

One size for a form

Every form here uses Kumo's default size: 36 px high with 14 px type. That matches the 14 px of Kumo's own fields, and is what a select, an input, a text area, the date field and a form's button share. Measured on this head at 1368 px:

  • Filter dialog: every select and field is 36 px with 14 px type. A select and the field beside it share top and bottom.
  • Automatic reply: the fields run from 541 to 989 px, and the button starts at 541.
  • Search options: the last row's "Search in" select and the two date fields all run from 543 to 579 px. Their labels differ by 2 px, because Kumo draws a select's label box at 22 px and its Label at 21.
  • Radio and checkbox labels are 13 px. That is Kumo's own choice for them, so I left it.

Seen and kept as Kumo draws them

A real fault fixed on the way

Inside a LayerDialog, a Select's list opened under the dialog's wrapper, which app/index.css sets at z-index 45. The wrapper took the click, so "Where it goes" could not be chosen with the mouse. A rule like the one for DropdownMenu places a positioner that holds a listbox at z-index 50. Kumo gives that positioner no part of its own, so the rule finds it by what it holds.

The browser tests, and why they changed

  • Kumo's select is a combobox with a listbox, and its value is its text. A helper in the fixtures, choose(), chooses an option as a person does.
  • Kumo's radios and checkboxes are found by role and name. Base UI renders a hidden input beside each, and the label names that input too, so getByLabel finds two.

Checks on this head

  • pnpm check passed: 22 static checks, 1,007 unit tests.
  • pnpm e2e passed, 91 tests.
  • The controls check passes at each of the six commits, run in throwaway worktrees.

Failed runs on this work, before this head:

  • My first full pnpm e2e, before the parking, failed 15 tests. Fourteen were the getByLabel finds above; the fifteenth was the z-index fault.
  • pnpm check failed twice before the parking: on formatting, and when the radio lookups took mailbox.spec.ts past 800 lines. Both are fixed inside the general tab's commit.

Pictures

On the orphan branch pictures, in pr-97/ at 15aa52a. Each is a throwaway local instance, under 300 KB.

General settings

Light Dark
Desktop, 1368 px
Phone, 390 px

The filter dialog

Light Dark
Desktop, 1368 px
Phone, 390 px

The automatic reply

Light Dark
Desktop, 1368 px
Phone, 390 px

Send later

Light Dark
Desktop, 1368 px
Phone, 390 px

Search options

Light Dark
Desktop, 1368 px
Phone, 390 px

🤖 Generated with Claude Code

Madraka and others added 6 commits November 19, 2026 02:41
The page-size select is Kumo's Select, and every choice of the tab is
Kumo's Radio.Group through Choice in settings/Row.tsx, its legend kept for
assistive technology. The tab's controls and its button use Kumo's default
size, whose 13 px type is the type of the radio labels and the row names
beside them. The language choice gives the focus back to the checked
radio by its role. Two lines of the controls check's debt go.

The browser tests change with the roles. They choose a page size as a
person does, through a helper in the fixtures: the select is now a
combobox with a listbox, and its value is its text. They find a radio by
its role and name inside its group: Kumo's radio is a span with the role
radio, and its label also names the hidden input beside it, so finding it
by its label finds two.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
The two "contains / is exactly" selects and "Where it goes" are Kumo's
Select, and the four checkboxes and the label boxes are Kumo's Checkbox, a
label's colour dot inside its label. Every field of the dialog uses Kumo's
default size, so a select and the field beside it are one height and their
lower edges line up, as #83 asks. Two lines of the controls check's debt
go.

The list of a select now opens above a dialog, as a menu's does
(app/index.css): in this dialog it opened under the dialog, which took the
click, so "Where it goes" could not be chosen with the pointer. Kumo gives
a select's positioner no part of its own, so the rule finds it by the list
it holds.

The browser tests choose "Where it goes" through the fixtures' helper,
read the comparison select by its text, and find the checkboxes by their
role and name: Kumo's select is a combobox whose value is its text, and
Kumo's checkbox is found twice by its label.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
… saves where its fields are

The on and off box is Kumo's Checkbox, the subject Kumo's Input at the
default size and the width of its column, and the message Kumo's
InputArea, grown to its text from eight rows. "Save automatic reply"
stands in the column of the fields, not under the names of the rows. The
two ends of "Between" stay the browser's own date-and-time field: Kumo's
DatePicker is a calendar with no time of day, so a field for both is a
wrapper to decide (#82). Their height and type are those of Kumo's
default size, and they stay in the controls check's debt.

The browser tests find "Answer mail that arrives" by its role and name,
as Kumo's checkbox is found twice by its label.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
…uses it

Kumo 2.18.1 has no field for a date and a time: its DatePicker is a
calendar only. app/components/controls/DateTimeField is the one place the
browser's own date field stands, drawn once at Kumo's default size with
Kumo's label above it, and the controls check keeps it as its one
ON_PURPOSE line, with that reason. Its limit is written there: the date
is shown in the device's form and language. The automatic reply's
"Starts" and "Ends" use it, and their two lines of debt go.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
The date and time of "Send later", and of "Change the time" of a waiting
message, is the DateTimeField of app/components/controls/, with its
label above it as before; its line of the controls check's debt goes.
The browser tests find it by its label as they did.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
…he one date field

"Label" and "Search in" are Kumo's Select, "Has an attachment" and
"Unread only" Kumo's Checkbox, "After" and "Before" the DateTimeField for
a date alone, and every field Kumo's default size. A label the search box
names that no longer exists is still offered, as before. Two lines of the
controls check's debt go.

The browser test chooses "Search in" through the fixtures' helper.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
@Madraka

Madraka commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Audit at 10b6763: one small correction, then pass

This time the screens were opened, not only read. I ran this head on a local instance with invented mail and measured each of the five screens at 1368 px; the general tab and the automatic reply also at 375 px and in the dark theme.

Opened and measured

Screen What I saw
General settings Kumo's select with its own arrows, 36 px; 35 radios, all Kumo's, none native. Nothing runs past the edge at 375 px; the dark theme draws the select and the radios in its own colours
The filter dialog Every select and field is 36 px with 14 px type. "Sender" and "A recipient" now stand at the row's left edge, above both the comparison and the field. A comparison and its field share top and bottom (268 to 304, 346 to 382). The list of "Where it goes" opens above the dialog and its four choices can be picked
The automatic reply The two date fields, the subject and the message run from 541 to 989; the save button starts at 541. At 375 px each takes the full width
Send later One label, one field of 36 px from 359 to 759, in Kumo's dialog
Search options Four fields, the label select, then one row of a select and two date fields that share top and bottom (543 to 579)

No native select, textarea or checkbox is left on any of the five. The console stayed clean.

Read

  • DateTimeField is the one place the browser's own field stands, with Kumo's Label, and it is the check's one ON_PURPOSE line with its reason. The debt goes from 62 to 46 and no list is raised.
  • The stacking rule in app/index.css is narrow: a positioner that holds a listbox, nothing else.
  • The tests changed for what changed: a select is found as a combobox and chosen from as a person would, and Kumo's radios and checkboxes are found by role and name.

To correct

The labels of one row do not stand on one line. In the search options' last row the label of "Search in" begins 2 px above the labels of the two date fields, as the description says: Kumo draws a select's label 22 px high and its Label 21. The three controls line up and their names do not, which is the kind of thing this work is for. The wrapper is ours, so it is the place to make its label stand where a Kumo select's does; the row then needs no class of its own. Measure it after, and say the numbers.

Kept as it is, and why

Seen on the way, not this change's

A draft with nothing in it is kept when the compose window is opened and left. That is how drafts work today; noted for whoever reads the drafts next.

The checks were still running when I read this.

… own

In the search options' last row, the label of "Search in" began 2 px above the labels of the
two date fields: Kumo's select puts its label on a line of its own, 8 px above the field, and
the wrapper put Kumo's Label straight above the field, 6 px apart. The wrapper now draws its
label the select's way, so a row of selects and date fields needs no class of its own.

Measured on the throwaway instance at 1368 px: the three labels of that row run from 513 to
534 and the three fields from 542 to 578. The automatic reply's "Starts" and "Ends" keep their
small label, now 8 px above the field; Send later's label is 8 px above its field.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
@Madraka

Madraka commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

audit: pass, once the required checks are green

Read at c90e794, and the row opened again on a local instance at 1368 px.

The text of the three labels of the search options' last row now stands on one line: "Search in", "After" and "Before" each from 523.0 to 539.5, and the select and the two date fields under them each from 550 to 586. The commit changes DateTimeField.tsx and nothing else, and the row has no class of its own.

Merge with a merge commit, and name the branch's runs. With this, #84's last part has been done once as it is meant to be done: the screens opened before the pass. The rest of #82's debt, 46 places, follows the same way, a screen for each commit.

@Madraka
Madraka merged commit 8089522 into main Nov 19, 2026
8 checks passed
@Madraka
Madraka deleted the fix/kumo-controls branch November 19, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant