Repository navigation
allow uneven FoVs for FRC calculation - #96
Open
tomasaidukas wants to merge 1 commit into
Open
tomasaidukas wants to merge 1 commit into
tomasaidukas wants to merge 1 commit into
Conversation
allevitan
requested changes
Oct 7, 2026
allevitan
left a comment
allevitan
left a comment
Collaborator
There was a problem hiding this comment.
I think the update needs to be applied to standardize_reconstruction_set too, and both docstrings need a short update. Otherwise looks great and a nice fix.
We don't have test coverage yet for these functions, so no need to add new tests just for this PR.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.