Skip to content

Let shared Ruff follow supported consumer Python versions #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shiny-code-app merged 1 commit into from
Nov 9, 2026
Merged

Let shared Ruff follow supported consumer Python versions #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions docs/tooling/style-checks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ uv run --project "${ODOO_DEVKIT_REPO:-../odoo-devkit}" --locked ruff format --ch

Ruff is supplied by devkit's locked development dependencies. The consumer's
pinned devkit checkout owns both its version and the shared configuration.
The shared configuration leaves `target-version` unset so normal Ruff discovery
uses the consumer's `pyproject.toml` `requires-python`: Python 3.14 for adopted
Odoo 20 consumers and Python 3.13 for supported Odoo 19 consumers. Devkit's root
tools retain their own Python 3.13 target. Consumers without Python project
metadata use Ruff's conservative default; an explicit consumer target still
takes precedence. Use normal configuration discovery, since passing a file with
`--config` disables version inference. See
[Ruff's version inference](https://docs.astral.sh/ruff/configuration/#inferring-the-python-version).

[`.idea/inspectionProfiles/Project_Default.xml`](../../.idea/inspectionProfiles/Project_Default.xml)
is the shared inspection asset. Keep it at that path as a regular
Expand All @@ -32,12 +40,13 @@ inspection remains disabled, as in both tenant profiles, following the amended
There is no Odoo SCSS scope: Odoo bundles assets across addons and uses QWeb
selectors the IDE does not index reliably.
Its Python compatibility
inspection checks 3.13 and 3.14, following the
inspection checks 3.13 and 3.14 for the supported consumers, following the
[Director decision](https://github.com/cbusillo/odoo-devkit/issues/302#issuecomment-6607466966).
Ruff continues to target the current 3.13 runtime. The
[image upgrade](https://github.com/cbusillo/odoo-devkit/issues/373) owns raising that
target after the images move. Tenant selection and pointer adoption remain on
the owning issue. Consumers declare the external profile path in
Both checks remain necessary while Odoo 19 and root tools support 3.13;
the profile has no separate Odoo 20 temporary target to retire. The
[Odoo 20 image qualification and preview proof](https://github.com/cbusillo/odoo-devkit/issues/373)
precede the consumer's 3.14 lint target. Tenant selection and pointer adoption
remain on the owning issue. Consumers declare the external profile path in
`qualityGate.inspection.profile`; task worktrees use the inspection helper's
`--profile` option when their devkit is outside the sibling layout. The
canonical file remains in devkit rather than in each consumer.
Expand Down
1 change: 0 additions & 1 deletion quality/ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
line-length = 133
target-version = "py313"

[lint]
select = ["ANN", "UP", "B", "I", "G", "BLE", "S608", "RET", "SIM"]
Expand Down
Loading