Repository navigation
Let shared Ruff follow supported consumer Python versions - #419
Conversation
|
Review result: weighed Anthropic claude-sonnet-5-5 completed the ordinary outside-provider review. No blocking defect; no second review or child worker ran. Declined as a current defect: metadata-free consumers receive Ruff's default rather than an explicit3.13 floor. Verified the actual shared snapshot at4928090: zero lint findings and176 files format clean; before/after lint JSON is byte-identical, and all176 tracked Python files parse under3.13. Ruff0.17.2 reports no explicit linter target and formatter/analyzer3.11, so the review's tentative3.10 default was inaccurate. This remains conservative and3.13 compatible. The docs explicitly state the fallback and --config limitation. No metadata or policy is invented for another repository. Declined as missing prerequisite: the actual current CM36eb2e4 source already declares >=3.14,<3.15; normal Ruff discovery resolves3.14. OPWae59c87 resolves3.13, as do root tools. Raising every shared caller to3.14 would violate the approved19 scope. There is no new test, duplicate policy or code modernization. The existing profile has no distinct20-only temporary entry; both3.13/3.14 checks still have supported consumers. Coverage: root lint/format, comment/diff checks, both offline locks and CLI smoke under3.13 pass. Actual lint output is unchanged on CM/OPW/shared; OPW's single existing I001 remains recorded. CM later pin adoption needs ten formatter-only exception-syntax updates. No tenant source is changed here. IDE: UNKNOWN / isolated_backend_unavailable / selection_file_type_unsupported for the exact changed .toml/.md files. No isolated worker supports those types; no native code/profile inspection pass is claimed. Native helper recommends reporting UNKNOWN, not retrying. This change has no Python/XML/JS or profile edits; Ruff itself exercised the changed configuration. |
|
The normal two-consumer gate passes for head0d8ab892acc24a149d171f00eab3423c5c0327cf. Both attempt1 consumer-build jobs succeeded; downloaded consumer-build-check-1 JSONs match runtime_commit to that exact head, their tenant source below and linux/amd64, with populated dependency_provenance.
The authoritative scope is the approved two consumers, reaffirmed by the closed third-consumer premise. No missing CM operations workflow was restored or counted as passing. All5current-head checks pass, including the full test suite, both analysis jobs, CodeQL and runtime lock. Weighed Sonnet review and explicit IDE UNKNOWN coverage remain current for this unchanged head. Local root Ruff lint/format, both offline locks, comment/diff checks and Python3.13 CLI smoke pass. Required documentation changed; quality metadata commands/ownership remain accurate. Readiness: engineering gates complete for this TOML/Markdown-only source change. The unsupported native inspection selection stays UNKNOWN, not clean; no Python/profile inspection pass is claimed. No image qualification, native data trial, image publication, runtime sync, deploy or production adoption occurred. |
|
Ready for the merge train Head: 0d8ab89 |
|
Launchplane completed the merge-train step for this pull request.
Launchplane finished the merge-train step for this pull request. Launchplane manages this comment and will update it as the train moves. Planning reconciliation is incomplete and needs owning-agent review. The merge landed; source planning metadata has not all been verified. Planning source completion requires owning-agent review. |
…ff25cf564615ab4: merge PR #419
Odoo 20 consumers declaring Python 3.14 still inherited a fixed Python 3.13 Ruff target. Remove that shared pin and use Ruff's existing requires-python inference. Current CM resolves3.14; OPW's supported19 source and devkit tools retain3.13. The shared inspection profile still serves both supported versions and has no separate20-only temporary entry to remove.
Closes #373 for the remaining scoped source follow-through. The historical preview prerequisite is fulfilled at https://github.com/cbusillo/odoo-tenant-cm/pull/356#issuecomment-6709242810; testing adoption, Client acceptance and runtime/data operations stay with their existing owners.
Validation: root Ruff lint/format, CLI smoke on Python3.13, both offline lock checks and comment/diff checks pass. Actual tracked CM/OPW/shared source snapshots resolve their expected targets; lint output is identical before/after (CM/shared clean; one existing OPW I001). OPW237 and shared176 tracked Python files parse under3.13. CM's later pin adoption needs formatter-only except-syntax updates in10 files; OPW/shared formatting pass. No maintained config-text test or source modernization was added.
One Anthropic claude-sonnet-5-5 review completed; no blocking defect. Weighed review, inspection coverage and exact-head CI/normal consumer receipts are recorded below before Ready.
Removed: the shared hard-coded target and obsolete global-runtime wording.
Net lines: +8 (14 added,6 removed); documentation explains built-in inference and the supported profile scope.
Client test notes
Nothing for the Client to test: shared development-tool configuration and documentation only; no product behavior or runtime changes.