Repository navigation
Launchplane batch: #6062 - #6063
Merged
Merged
Conversation
…0067f21eeb9b8ee: merge PR #6062
shiny-code-app
Bot
deleted the
launchplane/train/cbusillo/launchplane/main/merge-train-batch-cbusillo-launchplane-main-10067f21eeb9b8ee
branch
November 12, 2026 16:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR validates Launchplane's candidate
1ac9586f76cd99fce271a4830acfafaa652a6b3d. The train selects its protected landing route. Constituent PRs and reviewed heads:a9e2411b4dab3236d01d6de8256271afd278f4f1Launchplane revalidates every constituent and records the shared landing effect. Keep source PRs and branches intact. Let the Launchplane controller either merge this PR or close it after landing through the original PRs; do not merge it by hand or update its generated branch. An out-of-controller merge without a preceding admission remains fenced for explicit reconciliation. The controller confirms constituent completion after landing.
Owner test notes
#6062 Explain dependency refusals even without Ready or a label
Nothing for the Client to test: this changes merge-train explanations and leaves product behavior and acceptance unchanged.
Removed: the requirement for a dependency update to have a label or Ready before its refusal can be reported.
Net lines: +24 (+37, -13); one existing dependency fact carried into feedback, no new gate or command.
Closes #6060
Refs cbusillo/direction#172
Final qualification: Anthropic claude-opus-5-5 reviewed the final head and found no blocking defects. Its initial sibling-refusal finding was reproduced and fixed. Native PyCharm inspection is GREEN on all three changed Python files, complete execution, zero current findings and three preexisting findings excluded. Whole-repository Ruff passes, 2,177 files pass formatting, and mypy passes on 2,056 source files.
CI found one obsolete assertion in dependency requalification requiring a held dependency to receive no feedback. Removed that silence assertion and its now-unused import; candidate preservation, held-out identity, landing and next-candidate checks remain. The dedicated feedback test proves the new explanation. All 1,180 local merge-train tests pass (25 expected skips). Runtime code remains exactly the final reviewed source.