Repository navigation
Explain dependency refusals even without Ready or a label - #6062
3 commits merged into
Conversation
|
Review result: weighed Review result: weighed Anthropic claude-opus-5-5 reviewed the final source head c1f4e23 through the model-review helper. Final review: no blocking defects. Acted on: one medium finding in the first review. Matching dependency reason text omitted preview, Client-note and review-conversation refusals. Reproduced the preview and notes cases against the first fix (four failing subcases), replaced the text match with the existing dependency identity carried into the queue, and passed the extended behavior test. The second review checked all sibling refusal paths and confirmed unchanged admission and grants. Clarified: updates needing agent review are intentionally included; the sweep goal covers every dependency PR and the docs now state this. The final review's rollback observation found no stored-queue revalidation path and recommended no action; no reproduced change-specific defect remains. No open finding. Verification: 89 focused tests pass; whole-repo Ruff, formatting (2,177 files), mypy (2,056 files), and comment check pass. Final native PyCharm inspection is GREEN for all three changed Python files, zero current findings, three preexisting findings excluded, complete coverage. No frontend/UI behavior changed. |
|
Review result: weighed Review result: weighed Carried the completed Anthropic claude-opus-5-5 review from c1f4e23 to a9e2411. Runtime code and documentation are byte-for-byte unchanged. The only new commit removes the old dependency-requalification assertion that held dependencies must receive no feedback, plus its unused import and comment. It preserves all candidate, held-out, landing and re-entry assertions. The dedicated feedback regression test checks the explanation. CI reproduced exactly that obsolete assertion in four subcases; it reproduces locally before removal too. All 1,180 local merge-train tests now pass (25 expected skips), with Ruff, format and mypy clean on the corrected test. Native PyCharm inspection is GREEN on that fourth file, zero findings and complete execution. The preceding GREEN inspection still covers the unchanged three Python files. No new runtime behavior, source design choice or review finding was introduced; the one initial medium finding remains fixed, final review has no blocking defect. Removed: the obsolete silence assertion and unused import, in addition to the reporting prerequisite removed by this PR. |
|
Ready for the merge train Head: a9e2411 |
|
Launchplane completed the merge-train step for this pull request.
Launchplane landed this pull request through protected batch PR #6063. Launchplane manages this comment and will update it as the train moves. |
…0067f21eeb9b8ee: merge PR #6062
shiny-code-app
Bot
closed this pull request by merging all changes
into
main
in
690244f
Renovate PRs can sit without a train explanation even though the controller records the reason. cbusillo/odoo-tenant-cm#397 is refused for failed current-head checks, but has neither an enqueue label nor a Ready handoff, so the feedback filter drops it. Dependency updates normally need neither.
Carry the existing dependency-bot classification into the queue entry and use it in the shared feedback filter. All dependency refusals, including preview failures, Client-note errors and updates needing agent review, now reach the existing managed PR comment. Ordinary unrequested PRs remain quiet. Admission, policy, grants and Client acceptance rules are unchanged.
Verification: the extended queue behavior test fails on the previous source for dependency failures and review holds, and on the first fix for preview and notes holds. The final source passes all 1,180 merge-train tests (25 expected skips), plus Ruff and mypy on touched Python files. Outside review found the reason-prefix sibling gap and the final source uses dependency identity instead.
Client test notes
Nothing for the Client to test: this changes merge-train explanations and leaves product behavior and acceptance unchanged.
Removed: the requirement for a dependency update to have a label or Ready before its refusal can be reported.
Net lines: +24 (+37, -13); one existing dependency fact carried into feedback, no new gate or command.
Closes #6060
Refs cbusillo/direction#172
Final qualification: Anthropic claude-opus-5-5 reviewed the final head and found no blocking defects. Its initial sibling-refusal finding was reproduced and fixed. Native PyCharm inspection is GREEN on all three changed Python files, complete execution, zero current findings and three preexisting findings excluded. Whole-repository Ruff passes, 2,177 files pass formatting, and mypy passes on 2,056 source files.
CI found one obsolete assertion in dependency requalification requiring a held dependency to receive no feedback. Removed that silence assertion and its now-unused import; candidate preservation, held-out identity, landing and next-candidate checks remain. The dedicated feedback test proves the new explanation. All 1,180 local merge-train tests pass (25 expected skips). Runtime code remains exactly the final reviewed source.