Conversation
chapter_7.rst's doctest block refits and overwrites these files on every docs build, so tracking them in git made every doctest run look like an uncommitted change and fail the pre-push hook.
Adds py.typed, correlation.py, disposal.py, core/README.md, and test_architecture.py so test_package_directories_have_no_undocumented_members passes. This file was previously left unstaged, so pre-commit's stash/restore around hook runs was testing against the stale, undocumented version.
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 91 91
Lines 5400 5400
Branches 691 691
=======================================
Hits 4928 4928
Misses 338 338
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
# Conflicts: # pyproject.toml
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e191e5f. Configure here.

Summary of Changes
Adds whitespace rules to Ruff (E2 ruleset). I'm also adding our existing doctest to pre-commit, which was missing before.
Related GitHub Issue(s)
#651
Additional Context for Reviewers
#1203 was a false alarm, the two JSON files actually had changes due to changes in main. I believe these two files were supposed to be committed in a previous PR but were left out, so I checked them in.
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Medium Risk
JSON golden files and broad lint policy affect CI and numerical test expectations; doctest on every pre-push adds developer friction but does not change runtime behavior.
Overview
Ruff now enforces the E2 whitespace ruleset (with
previewon), excludes the invalid-syntax sandbox notebook, and expands per-file-ignores across library code, tests, and docs notebooks so existing violations stay grandfathered. CI and local hooks run Ruff on changed*.pyand*.ipynbwith--force-exclude, and the GitHub workflow fixes empty diffs onmainpushes by diffing againstgithub.event.beforewith fallbacks.Pre-commit consolidates hooks into one local repo: Ruff on pre-push diffs vs
origin/main(replacing the astral hook), plus a new doctest step that runssphinx-autogenand the Jupyter Book custom doctest builder.Test fixtures
friedland_ch7_xyz_paid.jsonandfriedland_ch7_xyz_reported.jsonare updated (Mack-related sub-triangle values). ARCHITECTURE.md is refreshed for current package layout;.gitignoregets a trailing newline on.vscode/.Reviewed by Cursor Bugbot for commit 264bd3d. Bugbot is set up for automated code reviews on this repo. Configure here.