Updating ruff ignore for previous fix - #1214
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 91 91
Lines 5400 5400
Branches 691 691
=======================================
Hits 4928 4928
Misses 338 338
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
running should those 5 lines in slice.py be fixed first or aligned with E2 updates in #1204? |
addressing now after resolving conflict |
priyam0k
left a comment
There was a problem hiding this comment.
looks good. thanks for updating the ignore rule. approving!
Summary of Changes
Removing ruff ignore for core/slicing.py
Related GitHub Issue(s)
Cleans up after #1103
Additional Context for Reviewers
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Config-only change to lint exemptions; no application logic or runtime behavior is modified.
Overview
Tightens Ruff per-file-ignores for
chainladder/core/slice.pyso only E225 stays grandfathered; E712, E721, and E741 are no longer suppressed there.That matches the lint cleanup from #1103—
slice.pyis now expected to satisfy those rules without exemptions.Reviewed by Cursor Bugbot for commit e177436. Bugbot is set up for automated code reviews on this repo. Configure here.