Skip to content

Updating ruff ignore for previous fix - #1214

Merged
priyam0k merged 2 commits into
mainfrom
update_slice_ruff_ignore
Aug 15, 2026
Merged

Updating ruff ignore for previous fix#1214
priyam0k merged 2 commits into
mainfrom
update_slice_ruff_ignore

Conversation

@henrydingliu

@henrydingliu henrydingliu commented Aug 13, 2026

Copy link
Copy Markdown
Member

Summary of Changes

Removing ruff ignore for core/slicing.py

Related GitHub Issue(s)

Cleans up after #1103

Additional Context for Reviewers

Checklist

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)

Note

Low Risk
Config-only change to lint exemptions; no application logic or runtime behavior is modified.

Overview
Tightens Ruff per-file-ignores for chainladder/core/slice.py so only E225 stays grandfathered; E712, E721, and E741 are no longer suppressed there.

That matches the lint cleanup from #1103slice.py is now expected to satisfy those rules without exemptions.

Reviewed by Cursor Bugbot for commit e177436. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 15.1% of exported symbols fully typed (201 / 1333)

Known Ambiguous Unknown Total
Project (head) 201 111 1021 1333

Other symbols referenced but not exported by chainladder: 13

Known Ambiguous Unknown Total
Other (head) 3 1 9 13

Symbols without documentation:

  • Functions without docstring: 321
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.25%. Comparing base (272cbe1) to head (e177436).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1214   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files          91       91           
  Lines        5400     5400           
  Branches      691      691           
=======================================
  Hits         4928     4928           
  Misses        338      338           
  Partials      134      134           
Flag Coverage Δ
unittests 91.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrydingliu
henrydingliu marked this pull request as ready for review August 13, 2026 23:22
@priyam0k

Copy link
Copy Markdown
Collaborator

running ruff check chainladder/core/slice.py --config "lint.per-file-ignores={}" still flags 5 errors in slice.py (E721, E741, E712 at lines 70, 177, 222, 759).

should those 5 lines in slice.py be fixed first or aligned with E2 updates in #1204?

@henrydingliu

Copy link
Copy Markdown
Member Author

running ruff check chainladder/core/slice.py --config "lint.per-file-ignores={}" still flags 5 errors in slice.py (E721, E741, E712 at lines 70, 177, 222, 759).

should those 5 lines in slice.py be fixed first or aligned with E2 updates in #1204?

addressing now after resolving conflict

@henrydingliu henrydingliu changed the title Update pyproject.toml Updating ruff ignore for previous fix Aug 15, 2026

@priyam0k priyam0k left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks for updating the ignore rule. approving!

@priyam0k
priyam0k merged commit 606be5c into main Aug 15, 2026
24 checks passed
@priyam0k
priyam0k deleted the update_slice_ruff_ignore branch August 15, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants