Repository navigation
Conversation
This was referenced Nov 20, 2026
xavipg003
force-pushed
the
dpe-11496-12
branch
from
November 20, 2026 14:56
63af964 to
85d7147
Compare
xavipg003
force-pushed
the
dpe-11496-12
branch
from
November 20, 2026 15:18
85d7147 to
3d55212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the migration of the PostgreSQL integration test modules from pytest-operator to jubilant. Buils on #440.
It migrates the remaining relations module,
test_new_relations_1, in its existing folder.What's included
new_relations/test_new_relations_1.py.charm/helpers.py:start_machine,assert_sync_standbysandcheck_database_users_existence, retaining the original LXC command, standby retry policy, first-unit selection, SQL and user assertions.get_app_leader,fast_forwardandwait_for_idle.scale_ha_application, preserving the original storage policy and exact-unit idle waits instead of using the general helper that destroys storage on VM scale-down.How the migration was done
ops_testwith the synchronousjujufixture and adapt deployment, relations, configuration, commands and status reads to jubilant.asyncio.gathercalls with sequential calls, andasyncio.sleepwithtime.sleep.wait_for_idlearguments using the existing synchronous compatibility helper.block_untilbecomesjuju.waitwith the original timeout and 0.5-second polling.base="ubuntu@24.04"for the originalseries="noble", which is not an argument of jubilant's deployment API.show_unitdata after the original idle wait: select by endpoint and related application, not by relation order.juju.integratedoes not return a relation object.hasattr(model, "list_secrets"): the pinned libjuju version has that method, so the original always runs these checks.