Repository navigation
[DPE-11496] (PART 4) CI/CD migration to single-kernel: merged common pytest-operator tests - #413
Merged
Merged
Conversation
xavipg003
force-pushed
the
dpe-11496-4
branch
from
November 5, 2026 16:48
3168a3d to
fc4dc5b
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
from
November 6, 2026 09:26
5463a82 to
de3c5a2
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
from
November 6, 2026 13:18
06df23d to
a400a94
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
from
November 6, 2026 14:30
a400a94 to
0f588cb
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
from
November 9, 2026 08:30
0f588cb to
c2b6129
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
from
November 9, 2026 09:42
56b7861 to
d0e7a82
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
from
November 10, 2026 08:49
7b47d8a to
943d993
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
from
November 10, 2026 14:25
7587141 to
57252ac
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
from
November 10, 2026 14:49
57252ac to
507e900
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
from
November 11, 2026 10:31
507e900 to
06198a4
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
from
November 11, 2026 10:33
06198a4 to
5044d13
Compare
xavipg003
marked this pull request as ready for review
November 12, 2026 11:32
xavipg003
requested review from
carlcsaposs-canonical,
dragomirp,
juju-charm-bot,
marceloneppel,
oleksii-buhaiov and
taurus-forever
November 12, 2026 11:32
xavipg003
force-pushed
the
dpe-11496-4
branch
2 times, most recently
from
November 16, 2026 13:59
c9a5689 to
ad111ab
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
2 times, most recently
from
November 18, 2026 12:34
f2a73e7 to
bca7f3c
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
2 times, most recently
from
November 19, 2026 09:17
9e125a8 to
c4abf4a
Compare
xavipg003
force-pushed
the
dpe-11496-4
branch
from
November 19, 2026 11:32
c4abf4a to
6c73f91
Compare
dragomirp
reviewed
Nov 20, 2026
| unit = [ | ||
| "coverage[toml]==7.16.2", | ||
| "pytest==9.1.1" | ||
| "pytest==9.1.1", |
Contributor
There was a problem hiding this comment.
NB: we should stick to 9.1 until we move away from pytest-operator.
Contributor
Author
There was a problem hiding this comment.
Moving away from pytest-operator starting on PR #431.
dragomirp
reviewed
Nov 20, 2026
Comment on lines
-28
to
-43
| parser.addoption( | ||
| "--controller", | ||
| default=None, | ||
| help="Juju controller to use (defaults to the current one).", | ||
| ) | ||
| parser.addoption( | ||
| "--model", | ||
| default=None, | ||
| help="Use this existing Juju model instead of creating a temporary one.", | ||
| ) | ||
| parser.addoption( | ||
| "--keep-models", | ||
| action="store_true", | ||
| default=False, | ||
| help="Keep the temporary models after the tests finish.", | ||
| ) |
Contributor
There was a problem hiding this comment.
Do those conflict with the pytest-operator defined ones? If not, I think we should keep them around, since the plan is to remove pytest-operator.
Contributor
Author
There was a problem hiding this comment.
Yes, they conflict. But in #445 they are added again when pytest-operator is removed.
dragomirp
reviewed
Nov 20, 2026
| assert application_connection_string != another_application_connection_string | ||
|
|
||
|
|
||
| # @pytest.mark.skip(reason="Unstable") |
Contributor
There was a problem hiding this comment.
We should check if this is still unstable.
Contributor
Author
There was a problem hiding this comment.
Checking locally, will uncomment on #444 if it seems stable.
dragomirp
approved these changes
Nov 20, 2026
taurus-forever
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR continues moving the PostgreSQL integration tests from the VM and K8s charm repos into the single kernel library. Builds on #412.
It focuses on the tests that use
pytest-operatorin both repos. Each test is merged into a single version that runs on both substrates, and stays onpytest-operatorfor now, as in the charm repos.What's included
ha_tests/:test_smoke,test_replication,test_self_healing_1,test_self_healing_2,test_self_healing_3,test_synchronous_policy,test_logical_replication,test_logical_replication_circular.new_relations/:test_new_relations_1,test_new_relations_2,test_relations_coherence.How the merge was done
Not done yet
pytest-operatorto jubilant will come in a later PR.