Skip to content

fix(settings): keep device controls within the popover #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fraserdale wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(settings): keep device controls within the popover #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "mobile-dev",
"version": "0.1.176",
"version": "0.1.177",
"private": true,
"workspaces": [
"packages/shared",
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const PLUGIN_VERSION = "0.1.176";
export const PLUGIN_VERSION = "0.1.177";
2 changes: 1 addition & 1 deletion packages/ui/src/components/device-settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export function DeviceSettings({ platform }: { platform: "ios" | "android" }) {
<AnimatedHeight>
<TabsContent value="app"><AppTools store={appTools} /></TabsContent>
<TabsContent value="device" className="space-y-3">
{settings && <fieldset disabled={disabled} className="space-y-3">
{settings && <fieldset disabled={disabled} className="min-w-0 space-y-3">
<Group label="Display">
{settings.appearance !== undefined && <Row label="Appearance" id={`${id}-appearance`}><Tabs value={settings.appearance} onValueChange={value => { if (value) void store.change({ setting: "appearance", value: value as "light" | "dark" | "auto" }); }}>
{/* Android's third option leaves no room for icons. */}
Expand Down