Skip to content

fix(settings): keep device controls within the popover - #83

Open
fraserdale wants to merge 1 commit into
callstackincubator:mainfrom
fraserdale:codex/fix-device-settings-overflow
Open

fraserdale wants to merge 1 commit into
callstackincubator:mainfrom
fraserdale:codex/fix-device-settings-overflow

Conversation

@fraserdale

@fraserdale fraserdale commented Nov 3, 2026 •

Copy link
Copy Markdown

Device settings can extend beyond the popover and clip the appearance controls, text-size stepper, and switches on the right. The settings fieldset retains its browser-default minimum content width, while the Panel section outside it fits correctly.

Add min-w-0 to the fieldset so it can shrink to the popover's available width. Bump the version to 0.1.177 as required by the contribution guide. Existing telemetry is unchanged because this only changes layout.

Validation

  • Reproduced in Chrome: the fieldset measured 336.28px inside a 326px content area before the fix.
  • With the fix, verified no fieldset overflow at popover widths of 360px, 328px, and 300px.
  • node --test packages/ui/test/react-ui.test.ts passed.
  • npm run test:visual:docker passed all four tests with no screenshot differences. These cover the workspace and sidebar in light/dark themes, not the open Device settings popover.
  • Confirmed visually in the contributor's live Mobile Dev panel.
  • git diff --check passed.

Before:
image

After:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant