Repository navigation
fix(settings): keep device controls within the popover - #83
Open
fraserdale wants to merge 1 commit into
Open
fraserdale wants to merge 1 commit into
fraserdale wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device settings can extend beyond the popover and clip the appearance controls, text-size stepper, and switches on the right. The settings fieldset retains its browser-default minimum content width, while the Panel section outside it fits correctly.
Add
min-w-0to the fieldset so it can shrink to the popover's available width. Bump the version to 0.1.177 as required by the contribution guide. Existing telemetry is unchanged because this only changes layout.Validation
node --test packages/ui/test/react-ui.test.tspassed.npm run test:visual:dockerpassed all four tests with no screenshot differences. These cover the workspace and sidebar in light/dark themes, not the open Device settings popover.git diff --checkpassed.Before:

After:
