Skip to content

test/c: leak-run.sh puts src/ on the include path - #272

Merged
gburd merged 1 commit into
masterfrom
fix/leak-run-srcinc
Nov 4, 2026
Merged

gburd merged 1 commit into
masterfrom
fix/leak-run-srcinc

Conversation

@gburd

@gburd gburd commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

#268 made lock_order_check.c include db_int.h, which includes dbinc/queue.h from src/. leak-run.sh compiles each driver with only -I$BUILD, so the resource-accounting + correctness leak drivers job fails at the build step on master (dc5e6bc92) and on the v2026.10.7.3 release PR #271. The job only runs when src/lock, src/txn, src/mp, src/os or test paths change, which is why #268's own CI did not run it.

Add -I$HERE/../../src, as the Makefile rule already has in CPPFLAGS. On Debian 12 every driver builds and lock_order_check passes all three arms.

Backport: needed on lts/2026.10.7 for the release PR to go green.

lock_order_check.c now includes db_int.h for the two-env arm (#268), and
db_int.h includes dbinc/queue.h from src/.  leak-run.sh builds each driver
with only -I$BUILD, so the leak job failed with "dbinc/queue.h: No such
file or directory" on master after #268 and on the v2026.10.7.3 release
PR.  The Makefile rule already has src/ in CPPFLAGS; this matches it.

Verified on Debian 12 (--enable-debug --enable-diagnostic): every driver
builds and lock_order_check passes all three arms.
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Coccinelle convention checks

No new violations. ✅

Resolved since baseline (3) -- update dist/cocci/baseline.txt to lock these in.
rule_mutex_unbalanced|MUTEX_UNBALANCED|src/btree/bt_curadj.c|return (ret);
rule_mutex_unbalanced|MUTEX_UNBALANCED|src/crypto/mersenne/mt19937db.c|return (ret);
rule_mutex_unbalanced|MUTEX_UNBALANCED|src/mp/mp_register.c|return (ret);

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

ABI diff vs v2026.10.8 (libabigail — authoritative)

abidiff exit bitmask: 0

Removed exported symbols (nm -D, _NNNN version suffix normalized)

None.


Advisory: libabigail/nm is the authoritative binary-ABI check; Coccinelle is complementary source-level early warning. See dist/cocci/README.md.

@gburd
gburd merged commit 90ac62f into master Nov 4, 2026
58 checks passed
@gburd
gburd deleted the fix/leak-run-srcinc branch November 4, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant