Repository navigation
[2026.10.7] test/c: leak-run.sh puts src/ on the include path - #273
Merged
Merged
Conversation
lock_order_check.c now includes db_int.h for the two-env arm (#268), and db_int.h includes dbinc/queue.h from src/. leak-run.sh builds each driver with only -I$BUILD, so the leak job failed with "dbinc/queue.h: No such file or directory" on master after #268 and on the v2026.10.7.3 release PR. The Makefile rule already has src/ in CPPFLAGS; this matches it. Verified on Debian 12 (--enable-debug --enable-diagnostic): every driver builds and lock_order_check passes all three arms. (cherry picked from commit 8ba0c85)
Contributor
Coccinelle convention checksNo new violations. ✅ Resolved since baseline (3) -- update dist/cocci/baseline.txt to lock these in. |
Contributor
ABI diff vs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #272 (
cherry-pick -xof 8ba0c85). #269 putdb_int.hinlock_order_check.c, andleak-run.shdid not havesrc/on its include path, so the leak job fails at the build step on the release PR #271. Test-only.