Repository navigation
fix(pr-management-stats): correct contributor timeline engagement - #2016
Open
MakerFlyFly wants to merge 1 commit into
Open
MakerFlyFly wants to merge 1 commit into
MakerFlyFly wants to merge 1 commit into
Conversation
Do not treat contributors' own label and draft-state events as maintainer engagement. Keep collaborator activity and closure signals unchanged so existing coverage and ready-label metrics retain their behavior. Cover the backlog counts, recommendations, closed-query shape, and written JSON sidecars with regression tests. Keep the generated magpie-security-tools dependency copy in sync. Generated-by: Codex (GPT-6)
Kaap10
approved these changes
Nov 6, 2026
Kaap10
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for the clean fix and thorough test coverage.
- Accurately addresses #2015 by ensuring contributor self-events (
ReadyForReviewEvent,ConvertToDraftEvent,LabeledEvent) do not falsely trigger maintainer engagement. - Safely handles casing discrepancies and deleted user accounts with
(author or "").lower(). - Preserves maintainer actions on contributor PRs and collaborator self-events.
- Full test suite passes cleanly with parity across both tool locations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LabeledEvent,ReadyForReviewEvent, andConvertToDraftEvent; preserve collaborator activity, closure actors, ready-label behavior, and label timestamps.Type of change
tools/pr-management/)Test plan
b6ccd434, six contributor regression cases fail and the other 30 targeted cases pass.prek run --all-files --skip workspace-pytestpasses, including lychee and the generated-plugin check.tools/pr-managementhas 795 passed and 15 subtests;pluginshas 114 passed and one container-permission probe skipped. Commit hooks were not bypassed.RFC-AI-0004 compliance
This corrects deterministic classification without adding fetched fields, configuration, dependencies, or service access.
Linked issues
Closes #2015.
Notes for reviewers
The PR is one commit based on upstream
main@b6ccd434.The four reviewed source/test blobs are unchanged; a fifth file is the generated magpie-security-tools copy of the classifier, byte-for-byte identical to the reviewed source.
A currently draft PR remains outside the untriaged non-draft counts.
The label case is defensive input coverage; ordinary external authors need repository triage permission to apply labels.
Closed-PR assertions deliberately retain legacy behavior within this repair's scope; they do not endorse contributor self-closure as maintainer engagement.
Strict actor authorization and comment/review engagement policy remain unchanged.
Suggested labels:
bug,family:pr-management,family:tools,capability:stats,capability:fix,substrate:analytics.Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-6).