Repository navigation
fix(pr-management-stats): correct contributor timeline engagement - #38
Draft
MakerFlyFly wants to merge 3 commits into
Draft
MakerFlyFly wants to merge 3 commits into
MakerFlyFly wants to merge 3 commits into
Conversation
Keep contributor PRs awaiting triage when their only activity is their own label or draft-state change. Preserve ready-label detection and label timestamps, and cover the dashboard counts and recommendations. Generated-by: Codex (GPT-6)
Limit author exclusion to contributors' label and draft-state events so closed-PR coverage and collaborator counts retain their prior behavior. Keep reduced fixtures faithful to closure actors and verify written sidecars as well as the dashboard metrics. Generated-by: Codex (GPT-6)
Explain that the closed-PR assertions preserve prior behavior within this repair's scope. A separate policy change may revise contributor self-closure expectations without being a regression in this repair. Generated-by: Codex (GPT-6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LabeledEvent,ReadyForReviewEvent, andConvertToDraftEventfrom engagement; a currently non-draft PR with no ready label or other engagement remains in the untriaged backlog.Type of change
tools/pr-management/)Test plan
Previously validated behavior repair (
088be38c)17abc4c8and passes 780 tests, plus 15 subtests.defacto=2andengaged_count=2.088be38c: nine successful checks, including pytest, tests-ok, prek, RAT, Zizmor, and Python analysis; the aggregate CodeQL entry is neutral.Final re-review
The supplied re-review reports no blocking findings.
Final follow-up
7a5f1bb3adds four comment lines to the two closed-PR tests; their executable AST and all assertions are unchanged from088be38c.A PR currently in draft still does not enter the untriaged non-draft counts.
Excluding an author's engagement event does not change that eligibility rule.
088be38c.b6ccd434, checked on 2026-11-06; no stats files changed since the previously tested upstream base.7a5f1bb3: nine successful checks; the aggregate CodeQL entry is neutral and Python analysis succeeds.RFC-AI-0004 compliance
This repairs deterministic classification.
It adds no service access, configuration, dependency, or fetched fields.
Linked issues
Closes #37.
Review follow-up
The three-version synthetic reproducer confirms closed coverage
100% -> 25% -> 100%and collaborator counts2 -> 1 -> 2.Only the closed-PR and collaborator contributions are preserved: the intended correction to open contributor engagement still affects aggregate coverage.
The first repair remains in history as
dfc050de; this revision is an additional commit.All changes stay in this fork's Draft PR. Re-review feedback reports no blockers; the final merge decision remains with the user.
The fork base remains
main@30ee18c2; the affected stats sources at that base and upstream17abc4c8match before this patch.Strict authorization of other actors and author COMMENTED reviews remain outside this PR.
Live API reachability of the latter has not been verified.
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-6).Upstream publication
The contributor completed review of the audited implementation
7a5f1bb3.7ca2d0cfbased on upstreamb6ccd434.The four audited source/test blobs are unchanged.
The upstream packaging hook additionally requires an identical generated classifier copy in magpie-security-tools.
This fork audit record and its published history are retained; the upstream PR is the formal review target.