Repository navigation
feat(release-management): add verify-rc live checklist pane mod scaffolding and UI component - #2007
Merged
potiuk merged 3 commits intoNov 5, 2026
Conversation
…olding and UI component Set up hooks scaffolding in plugins/magpie-release-management/hooks, declare verifyRcState atom and types, implement presentational Pane component with live status badges, and add unit test suite. Refs apache#2006, apache#1497 Generated-by: Antigravity (Gemini 2.5 Pro)
Check-family-plugins json.dumps serializer writes unicode-escaped \\u2014. Generated-by: Antigravity (Gemini 2.5 Pro)
…c pane The pane's checklist left out Steps 6b and 6c, which release-verify counts towards the verdict, so an RC with JVM artefacts had no row for a failure in either. Add them in STEP_ORDER's order. Use the sanitizer sequence from the review-findings mod: a line break in a detail could draw a second, false checklist row, and private-mode escape sequences left their text behind. Generated-by: Claude Opus 5
potiuk
approved these changes
Nov 5, 2026
potiuk
left a comment
Member
There was a problem hiding this comment.
Thanks: the mod follows the magpie-pr-management structure and stays additive and presentational. I found two things and fixed both in f95abda8, so you do not need another round:
hooks/types.ts: two missing steps. The checklist left outjvm-artefacts(Step 6b) andnexus-staging(Step 6c), whichSTEP_ORDERintools/release-verifycounts towards the verdict, so an RC with JVM artefacts had no row for a failure in either. It now has 13 steps. A step that does not apply should show asskipped, so please handle that in PR-2.hooks/verify-rc-pane.ts:sanitizeText. A line break in a detail could draw a second, false row such as[PASS] another check, and private-mode sequences like\x1b[?25lleft text behind. It now uses the same sequence assanitizeFindingTextin thereview-findingsmod. This matters once PR-2 feeds it tool output.
The tests in verify-rc-pane.test.ts are updated and cover both. The PR description still says 11 steps; the code now has 13.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
Contributing guide.
6 tasks done
potiuk
added a commit
that referenced
this pull request
Nov 5, 2026
Describe the ASF network scoping from #1978, including the claim it made false that containers share the sandbox's host allow-list. Record the run cost and pointer proof from #2000, the verify-rc pane from #2007, and the nine-skill pr-management family. Recheck every Known gaps bullet in eleven specs: delete those now closed, rewrite the stale ones, and annotate the rest with gap-closes-when. Generated-by: Claude Opus 5
17 of 22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins/magpie-release-management/hooks/and wires ambient type declarations in.claude-plugin/plugin.json(types.d.ts) alongside empty Codex hooks for multi-harness parity.verifyRcStateofficial state atom (atom()fromclaude-code), data interfaces, and canonical 11-step sequence matchingverify-rc/SKILL.md(Steps 0–10).Panecomponent with fixed-width status badges, ANSI text scrubbing, 60-character detail truncation, fail-open resilience, and 16 unit tests (claude plugin test).Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
claude plugin validate --strict plugins/magpie-release-managementpasses with 0 errors and 0 warningsclaude plugin test plugins/magpie-release-managementpasses (16/16 tests passing in 0.51s)python tools/dev/check-family-plugins.py(check_codex_hook_files()) passes with 0 errorsuv run pytest plugins/passes (107 passed, 0 failed)uv run ruff checkanduv run mypypass ontools/dev/check-family-plugins.pypython tools/dev/add-license-headers.py --checkpasses; all files verified strictly LF (crlf=0)RFC-AI-0004 compliance
Linked issues
Part 1 of #2006 (scaffolding & UI pane mod). Part of umbrella roadmap #1497.
Notes for reviewers (optional)
tool.call) to trackrelease-configandrelease-verifycommands and integrate withverify-rc/SKILL.md.