Repository navigation
fix(adversarial-review): review a PR's head, and close two gaps from #1997 - #2004
Merged
Merged
Conversation
…the label The pointer to release-manager-comments.md fired only when a pass proposed a transition. With a shipped release and a record still DRAFT the label cannot flip, so with no marker comment the agent never read the fill-fields rule. Trigger on the tracker's state instead: any open tracker labelled `pr merged` or `fix released`. Also strip a version suffix after a short project name in a title, such as "in Foo 2.1.0", which the earlier fix missed. A bare short name stays, since it may be a real word in the title. Generated-by: Claude Opus 5
The pre-PR block and security-issue-import-from-pr told agents to pass an empty temporary directory as --repo-dir for a PR with no local checkout. Reviewers there can read only the diff, so no findings is not a clean review. Give an export recipe that uses a throwaway repository, because that skill runs in the private tracker checkout, and warn in the report when --repo-dir is empty. Generated-by: Claude Opus 5
potiuk
enabled auto-merge (squash)
November 5, 2026 02:02
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--repo-dirwith a tested export of the PR's head, in the shared pre-PR block andsecurity-issue-import-from-pr.adversarial-review runnow warns when--repo-diris empty, and its refusal text no longer recommends an empty directory.in Foo 2.1.0now fails the title gate.What is and is not claimed about the empty directory. #1986 recorded that reviewers given an empty
--repo-dirreply without findings. That did not reproduce here, on PR #1997 with the configured reviewers:--repo-dircodex,copilotcodex,copilotantigravityhit a quota error in both runs. One PR neither proves nor disproves #1986, so the wording claims only what is certain: reviewers cannot read the surrounding code, so no findings is not a clean review.The pointer defect. The same runs flagged
signals-to-actions.md:546. With a shipped release and a record stillDRAFT, the label cannot flip, so the pass never proposes the transition, and with no marker comment the agent never read the fill-fields rule. The newcase-9failed on the merged pointer and passes 3/3 after the trigger became state-based: any open tracker labelledpr mergedorfix released, even when a gate blocks the next label.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/*/withpyproject.toml)Test plan
prek run --all-files --skip workspace-pytestpasses, includinglycheeworkspace-pytestpasses for the changed filessurface_hashchangedadversarial-reviewwarning, title gate)pointer-routing10/10,case-93/3,step-2b-proposed-changes12/12RFC-AI-0004 compliance
check-placeholdershook passesLinked issues
Follows #1986, #1997.
Notes for reviewers
pr mergedorfix releasedtracker now loads about 3.3k more tokens, even if it needs nothing. Correctness was chosen over that saving.security-cve-allocatechanges too. The title fix is in the sharedstrip().pull/<number>/headis GitHub's ref layout.prekandworkspace-pytestran after it.🤖 Generated with Claude Code