Skip to content

fix(frontend): sync package-lock.json; bundle build always runs npm ci (#130) #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amar-python merged 1 commit into from
Oct 27, 2026
Merged

fix(frontend): sync package-lock.json; bundle build always runs npm ci (#130) #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions csv-table-hub-main/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/QUICKSTART.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ For architecture and rationale see `docs/ARCHITECTURE.md`, `docs/VCRM.md`, and
|---|---|---|
| PostgreSQL | 17 or 18 | PG 18 recommended — installs on port 5433 by default |
| Python | 3.10+ | Must be on PATH |
| Node.js | 20+ | Required for the React frontend |
| Node.js | 22.12+ | Required for the React frontend (TanStack Start needs >=22.12) |
| Git Bash | Any | Required for bash scripts on Windows |
| psql client | Matching server | Windows: `C:\Program Files\PostgreSQL\<ver>\bin` |

Expand Down
2 changes: 1 addition & 1 deletion docs/offline-install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ The bundle is about 140 MB.

## 1. Build the bundle (connected machine)

You need Ubuntu 24.04 x86_64 with `git`, `python3-pip`, Node.js 20 or later and `apt-utils`. WSL Ubuntu 24.04 on Windows works.
You need Ubuntu 24.04 x86_64 with `git`, `python3-pip`, Node.js 22.12 or later and `apt-utils`. WSL Ubuntu 24.04 on Windows works. It must be 24.04, not a newer release, because the Ubuntu packages are downloaded from the build machine's own sources.

```bash
cd ~/PostgreDataMigrationAppWithCSVLoader
Expand Down
4 changes: 2 additions & 2 deletions scripts/offline/build_bundle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# build_bundle.sh: build the offline install bundle (#60).
#
# Run on an INTERNET-CONNECTED Ubuntu 24.04 x86_64 machine with git, python3-pip,
# Node.js 20+ and apt-utils installed, from the repo root:
# Node.js 22.12+ and apt-utils installed, from the repo root:
# bash scripts/offline/build_bundle.sh
# Output: dist/offline-bundle-<commit>.tar.gz plus its .sha256 file.
# Copy both to the offline VM and follow docs/offline-install.md.
Expand All @@ -29,7 +29,7 @@ echo "== 3/4 frontend, built for a plain Node server"
# The placeholder is replaced by install.sh with the real API address. No API key
# is built in: browsers sign in per user (#96).
( cd csv-table-hub-main
[ -d node_modules ] || npm ci
npm ci # always clean: a reused node_modules hid a stale lock file (see #130)
rm -rf .output
NITRO_PRESET=node-server VITE_API_BASE=__OFFLINE_API_BASE__ npm run build >/dev/null
cp -r .output "$OUT/frontend" )
Expand Down
Loading