Repository navigation
fix(frontend): sync package-lock.json; bundle build always runs npm ci (#130) - #131
Merged
Merged
Conversation
#130) npm ci failed on main with "Missing: lru-cache@11.5.3 from lock file". Regenerated with npm install --package-lock-only: one entry added (node_modules/nitro/node_modules/lru-cache), no version changes. build_bundle.sh no longer skips npm ci when node_modules exists, which is what hid this in the 26 Oct rehearsals. Node 22.12+ in the docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019YPoXzBSj89ZHgw7nfTmbB
This was referenced Oct 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130. It unblocks #60: phase A of the bundle build.
What changes
csv-table-hub-main/package-lock.jsonnpm install --package-lock-only(Node 22.23.4, npm 10.9.9). One entry added:node_modules/nitro/node_modules/lru-cache11.5.3. I compared the package list before and after, and no other package or version changed.scripts/offline/build_bundle.shnpm cialways runs. It used to run only whennode_moduleswas missing, which is how the stale lock got through the 26 Oct rehearsals. The header comment now says Node.js 22.12+.docs/offline-install.mddocs/QUICKSTART.md>=22.12.0).Checks
Run on a clean copy of
main'scsv-table-hub-main(git archive, nonode_modules):npm cifailed withMissing: lru-cache@11.5.3 from lock file. That reproduces the failure seen on the dev machine.npm ci: 508 packages added, exit 0;NITRO_PRESET=node-serverbuild OK (.output/server/index.mjsproduced).bash -n scripts/offline/build_bundle.sh: OK.Done when
Generated by Claude Code