Repository navigation
chore: bump go-ethereum to v1.17.7 (Glamsterdam block hash) - #1893
Merged
Merged
Conversation
arnaubennassar
approved these changes
Oct 7, 2026
joanestebanr
marked this pull request as ready for review
October 7, 2026 10:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Glamsterdam changes how the block hash is computed, so v1.17.4 produces wrong hashes for headers with the new fields. Go stays at 1.25.7 (already on 1.25). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
joanestebanr
force-pushed
the
chore/bump-go-ethereum-v1.17.7
branch
from
October 7, 2026 10:01
939a61d to
a080b77
Compare
joanestebanr
enabled auto-merge (squash)
October 7, 2026 10:24
joanestebanr
added a commit
that referenced
this pull request
Oct 7, 2026
…0.10] (#1894) ## 🔄 Changes Summary - Backport of #1893 to `release/0.10`: bump `github.com/ethereum/go-ethereum` v1.17.2 → v1.17.7. - Glamsterdam changes how the block hash is computed; older geth drops the new header fields when decoding and recomputes a wrong hash. - Go is already 1.25.7 on this branch, so no Go bump is needed. - Remove the SonarQube/SonarCloud integration (backport of #1719, as done in v0.6.4): drop the `SonarQube Scan` step from `.github/workflows/test-unit.yml`, rename the workflow to "Test Unit" and delete `sonar-project.properties`. SonarQube is no longer used, and its scan was failing in CI with HTTP 403 (`SONAR_TOKEN`). `test-unit.yml` now matches `develop`. ##⚠️ Breaking Changes - None (the Sonar removal is CI-only). ## ✅ Testing - 🤖 **Automatic**: `go build ./...`, and unit tests for `types`, `etherman`, `multidownloader`, `sync`, `l1infotreesync` pass. - 🖱️ **Manual**: not yet checked against a Glamsterdam-enabled node. ## 📝 Notes - The only header hash computation is `NewBlockHeaderFromEthHeader` (`types/block_header.go`), via `ethHeader.Hash()`; no manual hashing in aggkit. - This branch was on v1.17.2 (develop was v1.17.4), so `go mod tidy` pulls a larger set of transitive bumps (grpc, genproto, x/tools, ...). Worth a look from whoever owns the release. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔄 Changes Summary
github.com/ethereum/go-ethereumv1.17.4 → v1.17.7 (plus transitive bumps fromgo mod tidy).✅ Testing
go build ./..., and unit tests fortypes,etherman,multidownloader,sync,l1infotreesyncpass.📝 Notes
NewBlockHeaderFromEthHeader(types/block_header.go), which callsethHeader.Hash()on a gethtypes.Header(used byetherman/default_eth_client.go). It is fixed by the bump.DefaultEthClientalso has aHashFromJSONpath that takes the hash straight from the RPC response; it is unaffected either way.🤖 Generated with Claude Code