Skip to content

chore: bump go-ethereum to v1.17.7 (Glamsterdam block hash) [release/0.10] - #1894

Merged
joanestebanr merged 4 commits into
release/0.10from
chore/bump-go-ethereum-v1.17.7-release-0.10
Oct 7, 2026
Merged

joanestebanr merged 4 commits into
release/0.10from
chore/bump-go-ethereum-v1.17.7-release-0.10

Conversation

@joanestebanr

@joanestebanr joanestebanr commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

🔄 Changes Summary

  • Backport of chore: bump go-ethereum to v1.17.7 (Glamsterdam block hash) #1893 to release/0.10: bump github.com/ethereum/go-ethereum v1.17.2 → v1.17.7.
  • Glamsterdam changes how the block hash is computed; older geth drops the new header fields when decoding and recomputes a wrong hash.
  • Go is already 1.25.7 on this branch, so no Go bump is needed.
  • Remove the SonarQube/SonarCloud integration (backport of chore: remove SonarQube/SonarCloud integration #1719, as done in v0.6.4): drop the SonarQube Scan step from .github/workflows/test-unit.yml, rename the workflow to "Test Unit" and delete sonar-project.properties. SonarQube is no longer used, and its scan was failing in CI with HTTP 403 (SONAR_TOKEN). test-unit.yml now matches develop.

⚠️ Breaking Changes

  • None (the Sonar removal is CI-only).

✅ Testing

  • 🤖 Automatic: go build ./..., and unit tests for types, etherman, multidownloader, sync, l1infotreesync pass.
  • 🖱️ Manual: not yet checked against a Glamsterdam-enabled node.

📝 Notes

  • The only header hash computation is NewBlockHeaderFromEthHeader (types/block_header.go), via ethHeader.Hash(); no manual hashing in aggkit.
  • This branch was on v1.17.2 (develop was v1.17.4), so go mod tidy pulls a larger set of transitive bumps (grpc, genproto, x/tools, ...). Worth a look from whoever owns the release.

🤖 Generated with Claude Code

Glamsterdam changes how the block hash is computed, so older geth produces
wrong hashes for headers with the new fields. Go stays at 1.25.7.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@joanestebanr joanestebanr self-assigned this Oct 7, 2026
@joanestebanr
joanestebanr marked this pull request as ready for review October 7, 2026 10:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T10:10:58.093599Z cded00f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

joanestebanr and others added 2 commits October 7, 2026 12:28
Backport of #1719: drop the SonarQube Scan step from test-unit.yml and
delete sonar-project.properties.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Fixes govulncheck findings GO-2026-6443 (grpc) and GO-2026-5676 (quic-go).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Teku v24.12.0 occasionally wedges silently and freezes L1 block
production, so the MintableERC20 deployment in TestMain times out.
Backport the beacon-entrypoint.sh watchdog already present in develop.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@joanestebanr
joanestebanr merged commit 094c17a into release/0.10 Oct 7, 2026
23 of 24 checks passed
@joanestebanr
joanestebanr deleted the chore/bump-go-ethereum-v1.17.7-release-0.10 branch October 7, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants