Skip to content

AgentA@Area54: ci: the trailer check also rejects "Generated with" attribution lines #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muxagent merged 1 commit into from
Oct 7, 2026
Merged

AgentA@Area54: ci: the trailer check also rejects "Generated with" attribution lines #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/no-coauthor-trailers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
# Shared by both steps so the self-test actually exercises the same
# pattern the real check uses, not an independent hardcoded copy that
# could silently drift and keep passing after PATTERN regresses.
PATTERN: '(?m)^Co-authored-by:\s*.+<.+@.+>\s*$'
PATTERN: '(?m)^(Co-authored-by:\s*.+<.+@.+>|[^\w\n]*Generated with\s+\S.*)\s*$'

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep Generated-with matching on one line

Because \s+ also consumes newlines, a PR description or commit message containing a heading such as ## Generated with, followed by an ordinary paragraph, matches this pattern even though no attribution appears on that line. This causes the required check to reject legitimate prose; restrict the whitespace after with to horizontal whitespace so the required non-space content must occur on the same line.

Useful? React with 👍 / 👎.

steps:
- name: Self-test (negative control — must run before the real check)
run: |
Expand All @@ -34,8 +34,17 @@ jobs:
echo '{"commit":{"message":"docs: explain why Co-authored-by trailers are rejected"}}' \
| jq -e '.commit.message | test(env.PATTERN; "i") | not' >/dev/null \
|| { echo "::error::self-test failed: prose mention was incorrectly matched"; exit 1; }
echo '{"commit":{"message":"body\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)"}}' \
| jq -e '.commit.message | test(env.PATTERN; "i")' >/dev/null \
|| { echo "::error::self-test failed: known-bad Generated with line was NOT matched"; exit 1; }
echo '{"commit":{"message":"body\n\nGenerated with Claude Code"}}' \
| jq -e '.commit.message | test(env.PATTERN; "i")' >/dev/null \
|| { echo "::error::self-test failed: plain Generated with line was NOT matched"; exit 1; }
echo '{"commit":{"message":"docs: reject Generated with attribution lines in PRs"}}' \
| jq -e '.commit.message | test(env.PATTERN; "i") | not' >/dev/null \
|| { echo "::error::self-test failed: prose mention of Generated with was incorrectly matched"; exit 1; }

- name: Check commits and PR description for Co-Authored-By trailers
- name: Check commits and PR description for Co-Authored-By trailers and Generated with lines
env:
GH_TOKEN: ${{ github.token }}
REPO: ${{ github.repository }}
Expand All @@ -56,8 +65,8 @@ jobs:
--jq 'select(.body != null) | select(.body | test(env.PATTERN; "i")) | "PR body"')

if [ -n "$commit_violations" ] || [ -n "$body_violation" ]; then
echo "::error::Co-Authored-By trailer found."
echo "::error::Co-Authored-By trailer or 'Generated with' attribution line found."
[ -n "$commit_violations" ] && echo "Commits: $commit_violations — amend/rebase and force-push."
[ -n "$body_violation" ] && echo "PR description contains a trailer — edit the PR body to remove it."
[ -n "$body_violation" ] && echo "PR description contains one — edit the PR body to remove the line."
exit 1
fi
Loading