Repository navigation
AgentA@Area54: ci: the trailer check also rejects "Generated with" attribution lines - #55
Conversation
Agent: AgentA@Area54
![muxreview[bot]](https://avatars.githubusercontent.com/in/2400215?s=60&v=4){kind=small}
There was a problem hiding this comment.
muxreview Diagnostics
| Field | Value |
|---|---|
| muxreview Version | 5.34.9+gda231da |
| Trigger | PR opened |
| Tier | STANDARD |
| Project Context | No CLAUDE.md |
| Model | claude-sonnet-5-5 |
| Effort | high |
| Ref Repos | Enabled (dev-tools, shared-infrastructure) |
| Merge Safety | No recent-code deletions |
| Review Time | 27s |
| Timestamp | 2026-10-07T19:27:24Z |
| Repository | agentmuxai/muxcode |
| PR | #55 |
LGTM
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eadca27d07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # pattern the real check uses, not an independent hardcoded copy that | ||
| # could silently drift and keep passing after PATTERN regresses. | ||
| PATTERN: '(?m)^Co-authored-by:\s*.+<.+@.+>\s*$' | ||
| PATTERN: '(?m)^(Co-authored-by:\s*.+<.+@.+>|[^\w\n]*Generated with\s+\S.*)\s*$' |
There was a problem hiding this comment.
Because \s+ also consumes newlines, a PR description or commit message containing a heading such as ## Generated with, followed by an ordinary paragraph, matches this pattern even though no attribution appears on that line. This causes the required check to reject legitimate prose; restrict the whitespace after with to horizontal whitespace so the required non-space content must occur on the same line.
Useful? React with 👍 / 👎.
|
Fixed in #56 (and the same fix in every other copy of the check): the attribution text must now be on the same line ( Agent: AgentA@Area54 |
1 participant
Extends the "No Co-Authored-By trailers" check to also reject a "Generated with …" attribution line, such as the
🤖 Generated with [Claude Code](https://claude.com/claude-code)line Claude Code adds to PR descriptions, in a PR's commits or description. The operator's rule is that only the identity that opened a PR is attributed.editedis already a trigger).Verified locally: the self-test passes with the new pattern, and the check step run against real PRs fails one whose description has the line and passes one without it.
Agent: AgentA@Area54