Skip to content

fix(deps): exempt af-core releases from Dependabot cooldown - #2016

Merged
rismehta merged 1 commit into
masterfrom
fix/dependabot-af-core-cooldown
Nov 2, 2026
Merged

rismehta merged 1 commit into
masterfrom
fix/dependabot-af-core-cooldown

Conversation

@rismehta

@rismehta rismehta commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Description

Exempt released @aemforms/af-core versions from Dependabot's cooldown so they can be considered on the next scheduled or manual update check.

  • Branch from the latest fetched adobe/master, 16036c64c823be56676a6bfcfb15bf5771f106e4; refreshed again before publishing.
  • Add cooldown.default-days: 3 with @aemforms/af-core in cooldown.exclude.
  • Keep generated PRs targeted at dev, the npm /ui.frontend directory, exact dependency allowlist, daily schedule, one-open-PR limit, versioning strategy, labels, and commit prefix unchanged.
  • Change only .github/dependabot.yml; no dependency versions, lockfiles, application code, or CI pipeline changes.

The exclusion remains configured for future af-core releases until explicitly removed. Other dependencies are not added to the allowlist and are not exempted from cooldown.

Related Issue

#2013

Follow-up to #2014 and #2015.

Motivation and Context

Dependabot run 41432228201 succeeded, reached the npm registry, and found the published 1.0.11 tarball, but filtered out that release because of cooldown:

Filtered out 1 versions due to cooldown
Latest version is 1.0.10
No update needed for @aemforms/af-core 1.0.10

GitHub applies a default three-day cooldown even when no cooldown is explicitly configured. This package-specific exclusion allows our released af-core dependency to be considered without that wait.

GitHub reads this configuration from default branch master. After this PR is merged, use Insights > Dependency graph > Dependabot > Check for updates to retry. Scheduled checks remain enabled; an actual update PR still depends on successful dependency resolution and the normal update rules.

How Has This Been Tested?

Passed: live SchemaStore validation and exact-scope checks using an isolated Python environment with PyYAML/jsonschema:

python3 - <<'PY'
import json
from pathlib import Path
import subprocess
import jsonschema
import yaml
config = yaml.safe_load(Path('.github/dependabot.yml').read_text())
with __import__('urllib.request', fromlist=['urlopen']).urlopen('https://json.schemastore.org/dependabot-2.0.json', timeout=30) as response:
    jsonschema.validate(config, json.load(response))
baseline = yaml.safe_load(subprocess.check_output(['git', 'show', 'HEAD:.github/dependabot.yml'], text=True))
assert len(config['updates']) == 1
update = config['updates'][0]
assert update['target-branch'] == 'dev'
assert update['allow'] == [{'dependency-name': '@aemforms/af-core'}]
assert update.pop('cooldown') == {'default-days': 3, 'exclude': ['@aemforms/af-core']}
assert config == baseline
assert subprocess.check_output(['git', 'diff', '--name-only'], text=True).splitlines() == ['.github/dependabot.yml']
print('PASS: live Dependabot schema; exact af-core-only cooldown exclusion; all previous configuration preserved; one-file scope')
PY

The command above was run before committing the change, so HEAD is the unchanged master baseline.

Passed: git diff --check.

Not run: Maven/unit/Cypress suites, because this changes only Dependabot policy and does not change application code or dependencies. No test cases were added. Live Dependabot acceptance requires this configuration to be merged into master; the previous run demonstrates the cooldown issue, not acceptance of this unmerged configuration.

Screenshots (if appropriate):

Not applicable; configuration only.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

Keep the three-day default for other dependencies while allowing released @aemforms/af-core versions to be considered immediately. Preserve dev as the update PR target and all existing update settings.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rismehta
rismehta merged commit 66f7740 into master Nov 2, 2026
6 of 9 checks passed
@rismehta
rismehta deleted the fix/dependabot-af-core-cooldown branch November 2, 2026 11:34
@adobe-bot

Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

1 similar comment
@adobe-bot

Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

rismehta added a commit that referenced this pull request Nov 3, 2026
…#2019)

* Fix FORMS-22028: LOC: Unlocalized strings in "Configure" dialog for "Adaptive Form Scribble" component

* Fix FORMS-22023: LOC: Unlocalized strings in "Configure" dialog for "Adaptive Form Scribble" component

* chore(deps): propose af-core updates against dev

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(build): remove duplicate AEM SDK dependency

Keep the existing SDK dependency required by the NGDM image picker while removing the duplicate rejected by Maven 3.10.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(build): map legacy package IDs for Maven validation

Map content-package groups to real Maven coordinates in FileVault validation without changing installed package identities, dependency version ranges, plugin versions, or validation severity.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(ci): pin compatible Maven for the Java 21 build

Use checksum-verified Maven 3.9.16 instead of the floating image Maven 3.10, which is incompatible with FileVault 1.2.2 legacy dependency resolution. Restore unchanged package/plugin configuration and keep the Java 21 image current.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(ci): pin compatible Node and Lighthouse versions

Use Node 22.23.4 through the pinned official Node orb for both shared browser jobs and pin Lighthouse 13.6.0 exactly. Node 20.10 lacks import.meta.dirname, causing Lighthouse to scan undefined/locales. Keep audit logic and thresholds unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Merge pull request #2016 from adobe/fix/dependabot-af-core-cooldown

fix(deps): exempt af-core releases from Dependabot cooldown

* chore(deps): bump @aemforms/af-core from 1.0.10 to 1.0.11 in /ui.frontend (#2017)

* chore(deps): bump @aemforms/af-core in /ui.frontend

Bumps [@aemforms/af-core]() from 1.0.10 to 1.0.11.

---
updated-dependencies:
- dependency-name: "@aemforms/af-core"
  dependency-version: 1.0.11
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(ci): temporarily disable automatic PR base resync

Use GitHub Update branch instead of automatically rebasing and force-pushing pull-request branches. Dependabot-triggered resync failed with a read-only workflow token (403). Skip the sync job for all PRs without changing permissions or the af-core dependency update.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* chore(ci): remove obsolete PR resync workflow

Remove sync-pr.yml entirely instead of retaining a disabled job. Use GitHub Update branch when synchronization is needed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rishi Mehta <rismehta@adobe.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* @releng [maven-scm] :prepare release core-forms-components-reactor-3.0.176

* @releng [maven-scm] :prepare for next development iteration

* Update VERSIONS.md and README.md to include version 3.0.176

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Artem Sova <alp60583@adobe.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: ci-build <ci-build@aemforms>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants