Repository navigation
fix(teardown): allow cleanup after a verified Herdr pane move - #415
Merged
Merged
Conversation
Keep the same running Herdr session without requiring persistent cwd relocation. Warn before approval that later tools or exit may report a deleted directory. Finish own-checkout cleanup in one shell rooted at main. Retain other-session, data-preservation, merge, and Orca guards.
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore approved teardown after a verified Herdr pane move, so missing persistent cwd controls no longer block cleanup.
The same process stays alive. Later tools or exiting the agent can report a deleted-directory error; the plan must disclose that risk before approval.
How it works
flowchart TB A[Check data, merge status, and other sessions] --> B[Disclose stale-cwd risk and obtain approval]:::changed B --> C[Move the same pane to the main workspace] C --> D{Pane identity verified?}:::changed D -->|No| E[Keep checkout and branches] D -->|Yes| F[Finish other approved cleanup] F --> G[Remove own checkout and finish cleanup in one shell rooted at main]:::changed classDef changed stroke-width:3pxA verified Herdr pane move permits approved removal even when the agent's working directory stays behind.
What changed
Blast radius
Test plan
Verification limits
The live test moves a real pane but deletes nothing. Destructive cleanup and post-deletion tool or exit errors remain untested.
The local test isolates the skill from the ACStack extension. No AI review workflow is configured in this repository.