Name the seven new samples on the pages they belong to - #322
Merged
Merged
Conversation
abap2UI5/samples is adding seven samples for framework capabilities its
catalogue never showed, and each carries a `" @docs` line pointing at a page
here. That pairing is declared on THIS side - a page's `samples:` frontmatter -
and generated on both, so a sample pointing at a page that does not name it
back fails `check-docs-links` over there. This is that half.
cookbook/event_navigation/frontend 513, 514, 515, 518
the css pseudo-method, aggregation items addressed by index, the global
BusyIndicator, and registering an icon font - four more of the frontend
actions this page is about
cookbook/browser_interaction/soft_keyboard 516
beside 352: that one asks for the keypad with the keyboard_set_mode
action, this one binds z2ui5.cc.InputExt's inputMode property instead
cookbook/device_capabilities/upload_download 517
beside 074's FileUploader: the same job through sap.m.upload.UploadSet
cookbook/translation_messages/translation_i18n 519
the page had no samples block at all until now
The generated blocks are rewritten with `npm run link:samples`.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019rmo8XKoBEpBRZ2TZMUQrF
oblomov-dev
pushed a commit
to abap2UI5/samples
that referenced
this pull request
Sep 14, 2026
The pairing is checked from both sides against the OTHER repository's `main` (check-docs-links here reads abap2UI5/docs at main; link-samples.mjs there reads this catalogue at main), so a new sample and its page entry cannot land together: each gate fails on what the other has not merged yet. The classes go in without their `" @docs` line, abap2UI5/docs#322 then has classes to name, and a follow-up here adds the seven lines back against a docs main that already carries them. Three green merges instead of two red ones. Generated artefacts regenerated: the `docs:` row in SAMPLES.md and the catalogue entries come off with the lines. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019rmo8XKoBEpBRZ2TZMUQrF
oblomov-dev
added a commit
to abap2UI5/samples
that referenced
this pull request
Sep 14, 2026
The other half of the pairing abap2UI5/docs#322 declares: 513, 514, 515 and 518 at cookbook/event_navigation/frontend, 516 at browser_interaction/soft_keyboard, 517 at device_capabilities/upload_download, 519 at translation_messages/translation_i18n. The docs: rows in SAMPLES.md and the catalogue entries come back with them. A second pull request because each side checks the pairing against the OTHER repository's main, in both directions - check-docs-links here wants the page to name the class, link-samples.mjs there wants the class to point back - so the two halves can never both be green before both have merged. #844 went in without these lines to keep that side clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
abap2UI5/samples is adding seven samples for framework capabilities its catalogue never showed, and each carries a
" @docsline pointing at a page here.That pairing is declared on this side — a page's
samples:frontmatter — and generated on both, so a sample pointing at a page that does not name it back failscheck-docs-linksover there. This is that half, and it has to land first.cookbook/event_navigation/frontendcsspseudo-method, aggregation items addressed by index, the global BusyIndicator, and registering an icon fontcookbook/browser_interaction/soft_keyboardkeyboard_set_modeaction, this one bindsz2ui5.cc.InputExt'sinputModeproperty insteadcookbook/device_capabilities/upload_downloadsap.m.upload.UploadSetcookbook/translation_messages/translation_i18nsamples:block at all until nowThe generated blocks are rewritten with
npm run link:samples; nothing else on any page changes.All gates pass locally:
test,check:conventions,check:examples,check:playground,check:api-names,check:api-reference,check:samples,check:design,check:images.🤖 Generated with Claude Code
https://claude.ai/code/session_019rmo8XKoBEpBRZ2TZMUQrF
Generated by Claude Code